1
0
Fork 0
forked from OpenNeo/impress
impress/app
Matchu f8cf3fd701 Fix crash when searching for "is:nc"
Huh, Arel can *sometimes* handle just having an attribute stand in as
"X is true" in a condition, but sometimes gets upset about it. I guess
this changed in Rails since we recently wrote this?

Specifically, item search would crash on "is:nc" (but *not* "is:np"),
saying:

```
undefined method `fetch_attribute' for #<struct Arel::Attributes::Attribute relation=#<Arel::Table:0x0000000109a67110 @name="items", @klass=Item(…), @type_caster=#<ActiveRecord::TypeCaster::Map:0x0000000109a66e90 @klass=Item(…)>, @table_alias=nil>, name="is_manually_nc">
```

The traceback was a bit misleading (it happened at the part where we
merge all the scopes together), but that hinted to me that it working
with an attribute in a place where it expected a conditional. So I
converted the attribute in the `is_nc` scope to a conditional, and made
the matching change in `is_np`, and that fixed it! Ok phew!
2023-10-25 12:46:48 -07:00
..
assets Delete outfits/show page, point to the editor instead 2023-10-24 18:02:18 -07:00
controllers Delete unused roulette feature 2023-10-24 19:05:18 -07:00
helpers Remove slightly-broken edit outfit links from user outfits page 2023-10-24 18:05:51 -07:00
javascript Use /outfits/1234 URLs in the editor 2023-10-24 17:29:07 -07:00
mailers donation mailer 2014-09-10 14:32:54 -05:00
models Fix crash when searching for "is:nc" 2023-10-25 12:46:48 -07:00
views Oops, fix silly bug on /outfits/new 2023-10-24 19:10:05 -07:00