1
0
Fork 0
forked from OpenNeo/impress
Dress to Impress, a big fancy Neopets customization tool!
Find a file
Matchu f8cf3fd701 Fix crash when searching for "is:nc"
Huh, Arel can *sometimes* handle just having an attribute stand in as
"X is true" in a condition, but sometimes gets upset about it. I guess
this changed in Rails since we recently wrote this?

Specifically, item search would crash on "is:nc" (but *not* "is:np"),
saying:

```
undefined method `fetch_attribute' for #<struct Arel::Attributes::Attribute relation=#<Arel::Table:0x0000000109a67110 @name="items", @klass=Item(…), @type_caster=#<ActiveRecord::TypeCaster::Map:0x0000000109a66e90 @klass=Item(…)>, @table_alias=nil>, name="is_manually_nc">
```

The traceback was a bit misleading (it happened at the part where we
merge all the scopes together), but that hinted to me that it working
with an attribute in a place where it expected a conditional. So I
converted the attribute in the `is_nc` scope to a conditional, and made
the matching change in `is_np`, and that fixed it! Ok phew!
2023-10-25 12:46:48 -07:00
.vscode Add the Pardon Our Dust page 2023-10-23 19:05:09 -07:00
app Fix crash when searching for "is:nc" 2023-10-25 12:46:48 -07:00
bin Precompile assets when deploying new version 2023-10-23 19:05:09 -07:00
config Delete unused roulette feature 2023-10-24 19:05:18 -07:00
db Stop orphaning hangers when deleting lists 2023-10-24 15:35:21 -07:00
deploy Convenient shell things when logging in as impress user in production 2023-10-24 16:03:22 -07:00
doc rails 3 2010-05-14 18:12:31 -04:00
lib Fix AMFPHP requests 2023-10-23 19:05:09 -07:00
public Stop saving local copies of SWFs 2023-10-23 19:05:10 -07:00
script rails 3 2010-05-14 18:12:31 -04:00
spec Delete WardrobeTip model 2023-10-23 19:05:05 -07:00
test core of pet loading, still needs get image hash, download assets 2010-10-07 10:46:23 -04:00
tmp utf-8 support in both ruby 1.9 and 1.8 2011-06-04 18:40:15 -04:00
vendor Security updates 2023-10-23 19:08:56 -07:00
.gitignore Remove Vagrant config 2023-10-23 19:05:09 -07:00
.ruby-version Upgrade to Ruby 3.1.4 2023-10-23 19:05:07 -07:00
config.ru Upgrade to Rails 6.1.7.4 2023-10-23 19:05:07 -07:00
Gemfile Security updates 2023-10-23 19:08:56 -07:00
Gemfile.lock Security updates 2023-10-23 19:08:56 -07:00
LICENSE.md Update our license 2023-10-23 19:04:56 -07:00
package.json Add Prettier to dev dependencies 2023-10-24 16:37:06 -07:00
Procfile.dev Bundle wardrobe-2020 into the app 2023-10-23 19:05:08 -07:00
Rakefile Uninstall resque 2023-10-23 19:05:04 -07:00
README replace standard rails readme :P 2010-07-07 02:31:47 -04:00
yarn.lock Add Prettier to dev dependencies 2023-10-24 16:37:06 -07:00

An extension of Dress to Impress (PHP) that runs on Ruby on Rails.
I wanted to use Rails initially for Impress, but hoped that using
PHP would allow me to attract more developers. Looks like that
wasn't the case, so I just went with what I loved and made the
items database in Rails.

Future Impress sections will likely find themselves in this
project, rather than the PHP project.