1
0
Fork 0
forked from OpenNeo/impress
impress/app
Emi Matchu 30eced448d Fix bug precompiling a CSS file that contains a min() expression
When I run `bin/deploy:precompile` on the previous version, I get an
error from libsass that `vw` and `vh` are incompatible units. I don't
get this error in development, only when compiling for production.

My inference is:
1. For the production build, Sass is trying to preprocess even non-SASS
   files, maybe to help minify them?
2. In Sass, their `min()` existed before CSS's `min()`, so it's
   treating it Like That, and returning a reasonable-in-some-cases-but-
   not-here error that `min(100vw, 100vh)` can't be *precomputed*.

Anyway, wrapping it in `calc()` isn't a *problem*, and helps the Sass
compiler not try to precompute it, so. Okay!
https://github.com/sass/node-sass/issues/2815#issuecomment-575926329
2024-09-06 11:00:49 -07:00
..
assets Fix bug precompiling a CSS file that contains a min() expression 2024-09-06 11:00:49 -07:00
controllers Add html5 badge to new item previews 2024-09-05 18:48:41 -07:00
helpers Add responsive layout for item page 2024-09-05 16:18:48 -07:00
javascript Merge branch 'main' into simpler-item-previews 2024-07-09 14:26:47 -07:00
mailers/fundraising Move most fundraising files into a Fundraising module 2024-02-18 20:12:14 -08:00
models Add html5 badge to new item previews 2024-09-05 18:48:41 -07:00
services Load *all* NC Mall pages in nc_mall:sync 2024-05-10 17:39:40 -07:00
views Add html5 badge to new item previews 2024-09-05 18:48:41 -07:00