1
0
Fork 0
forked from OpenNeo/impress
Dress to Impress, a big fancy Neopets customization tool!
Find a file
Emi Matchu 30eced448d Fix bug precompiling a CSS file that contains a min() expression
When I run `bin/deploy:precompile` on the previous version, I get an
error from libsass that `vw` and `vh` are incompatible units. I don't
get this error in development, only when compiling for production.

My inference is:
1. For the production build, Sass is trying to preprocess even non-SASS
   files, maybe to help minify them?
2. In Sass, their `min()` existed before CSS's `min()`, so it's
   treating it Like That, and returning a reasonable-in-some-cases-but-
   not-here error that `min(100vw, 100vh)` can't be *precomputed*.

Anyway, wrapping it in `calc()` isn't a *problem*, and helps the Sass
compiler not try to precompute it, so. Okay!
https://github.com/sass/node-sass/issues/2815#issuecomment-575926329
2024-09-06 11:00:49 -07:00
.devcontainer Save last trade activity time onto User 2024-01-19 00:00:46 -08:00
.husky Set up eslint for wardrobe-2020 2023-11-02 18:11:07 -07:00
app Fix bug precompiling a CSS file that contains a min() expression 2024-09-06 11:00:49 -07:00
bin Add Solargraph autocomplete while in development 2024-07-01 15:35:39 -07:00
config Merge branch 'main' into simpler-item-previews 2024-08-31 12:50:56 -07:00
db Make thumbnail_url a manually overridable field for Alt Styles 2024-06-15 17:35:12 -07:00
deploy Upgrade to Ruby 3.3.4 in production 2024-08-31 12:49:50 -07:00
lib Ensure rails public_data:pull doesn't use SSL for localhost 2024-07-07 17:21:54 -07:00
public Add a cute Ghost Acara to the 404 page 2024-04-20 21:31:27 -07:00
test Save last trade activity time onto User 2024-01-19 00:00:46 -08:00
vendor Add x86_64 versions of some of the cached gems 2024-08-31 12:08:14 -07:00
.eslintrc.json Set up eslint for wardrobe-2020 2023-11-02 18:11:07 -07:00
.gitignore Create rails public_data:commit task, to share public data dumps 2024-02-29 14:30:33 -08:00
.ruby-version Update Ruby to 3.3.4, and update gems 2024-08-27 17:06:22 -07:00
.solargraph.yml Add Solargraph autocomplete while in development 2024-07-01 15:35:39 -07:00
.yarnrc.yml Upgrade to Yarn 4.0.2 2024-01-14 23:05:53 -08:00
config.ru Upgrade to Rails 6.1.7.4 2023-10-23 19:05:07 -07:00
falcon.rb Remove supervisor from the Falcon process? 2024-01-24 00:20:23 -08:00
Gemfile Update Ruby to 3.3.4, and update gems 2024-08-27 17:06:22 -07:00
Gemfile.lock Update Ruby to 3.3.4, and update gems 2024-08-27 17:06:22 -07:00
LICENSE.md Update GitHub links to point to our self-hosted OpenNeo Code 2024-02-29 11:24:21 -08:00
package.json Upgrade typescript-eslint dependencies 2024-05-06 15:08:37 -07:00
Procfile.dev Use local-only HTTPS certs for the development neopass-server 2024-03-14 18:01:54 -07:00
Rakefile Uninstall resque 2023-10-23 19:05:04 -07:00
README.md Oops, needs to be a README.md file! 2023-10-25 16:31:41 -07:00
yarn.lock Upgrade typescript-eslint dependencies 2024-05-06 15:08:37 -07:00

Dress to Impress beach logo

Dress to Impress

Oh! We've been revitalizing the Rails app! Fun!

There'll be more to say about it here soon :3