Emi Matchu
1e99376449
I think the Rails query cache handled these anyway? But `SwfAsset` has a `before_save` hook that checks its zone's info, and `SwfAsset.preload_manifests` saves all the assets, on the assumption that saving is a no-op when the record didn't change anyway. And it basically is! But I figure that, now that I'm realizing hooks exist, simply not attempting to save unchanged records is probably a better representation of what we intend to do. So I'm fixing it like that! Another potential fix would be to preload the zones for these assets, but I think that confuses the intent too much; the method itself isn't using the zones, it's just a weird incidental thing that a save hook happens to use. (Would probably be better to refactor this old save hook into a different situation altogether, but that's for another time!) |
||
---|---|---|
.. | ||
fundraising | ||
item | ||
alt_style.rb | ||
application_record.rb | ||
auth_record.rb | ||
auth_user.rb | ||
closet_hanger.rb | ||
closet_list.rb | ||
closet_visibility.rb | ||
color.rb | ||
contribution.rb | ||
item.rb | ||
item_outfit_relationship.rb | ||
nc_mall_record.rb | ||
neopets_connection.rb | ||
neopets_page.rb | ||
outfit.rb | ||
parent_swf_asset_relationship.rb | ||
pet.rb | ||
pet_state.rb | ||
pet_type.rb | ||
species.rb | ||
swf_asset.rb | ||
user.rb | ||
zone.rb |