Slim the PosePicker down, and show the worn style in the outfit list #42

Merged
matchu merged 2 commits from armin-bot/impress:claude/slim-pose-picker into main 2026-11-18 09:47:09 -08:00
Contributor

Step 3 of the NC Pet Styles plan: the PosePicker stops being a second place to browse styles, and points to NC Pet Styles search instead. The worn style also gets a row in the outfit list.

Screenshots

No style worn Style worn
The popover: the expression grid, then an "NC Pet Styles · 143 styles" row The popover with a style worn: the style, "Change style" and "Remove", and a note about expressions

The outfit list, starting with an "NC Pet Style" group: the token thumbnail, "Prismatic Cyan: Nostalgic Faerie Aisha", NC and Pet Style badges, and change, remove and info buttons

Phone width The popover at phone width, opening below the pet, with the NC Pet Styles row The outfit list at phone width, with the NC Pet Style row and its buttons showing

What changes for users

  • No style worn: the popover shows the expressions as before, then an NC Pet Styles row with the species' style count. It closes the popover and opens the styles search, with the cursor in the field (except on touch devices, where the keyboard would cover the grid).
  • Style worn: the popover shows that style instead of expressions, with Change style (to the search) and Remove, plus a note that styles come with their own expression.
  • Outfit list: an NC Pet Style group comes first while a style is worn. Its row isn't a toggle like item rows: its buttons are Change style, Remove, and More info (the token's item page, for named styles).
  • The Expressions and Styles tabs are gone.

Under the hood

  • WardrobePage has a stable browseStyles callback, passed to the PosePicker (through WardrobePreviewAndControls and OutfitControls) and to ItemsPanel. If you're already in styles mode it keeps your text. It also bumps a searchFocusRequest counter that ItemsAndSearchPanels uses to focus the field.
  • The popover turns off returnFocusOnClose when it closes for this, or focus would bounce back to its button.
  • StyleSelect and its hover preview leave the PosePicker, and matchesDefaultStyle goes with it.
  • Server: the alt styles JSON includes full_name, for the outfit row's title. The controller spec checks it.

Testing

yarn lint, Prettier and the controller spec pass. In Chromium against a local server with public data:

  • The NC Pet Styles row closes the popover, opens the styles search and focuses the field.
  • Wearing a style shows the outfit row, and the popover shows the worn card, with "Change style" focused.
  • Remove in the popover switches back to expressions, and the outfit row goes away.
  • A ?style= URL shows the outfit row and the worn card.
  • Change style, from the outfit row or the popover, opens the styles search with the worn tile checked and the field focused, including when already in that mode.
  • The outfit row has a normal cursor, and its buttons show on hover.
  • Phone emulation: the popover and outfit row lay out as shown above.

A fresh-eyes review pass found the outfit row looked clickable; that's fixed in the last commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_014PWWczDoFB58ZYFZ68WxeS

Step 3 of the NC Pet Styles plan: the PosePicker stops being a second place to browse styles, and points to NC Pet Styles search instead. The worn style also gets a row in the outfit list. ## Screenshots | No style worn | Style worn | |---|---| | ![The popover: the expression grid, then an "NC Pet Styles · 143 styles" row](https://code.openneo.net/attachments/495cf9ce-d158-4be9-a575-754389b45ec9) | ![The popover with a style worn: the style, "Change style" and "Remove", and a note about expressions](https://code.openneo.net/attachments/8c46d325-0a98-4315-8fe0-5116f1211ede) | ![The outfit list, starting with an "NC Pet Style" group: the token thumbnail, "Prismatic Cyan: Nostalgic Faerie Aisha", NC and Pet Style badges, and change, remove and info buttons](https://code.openneo.net/attachments/ee4384b8-3fea-423a-8ad7-5541860af517) <details><summary>Phone width</summary> <img src="https://code.openneo.net/attachments/bac87967-063a-43a5-9a96-254c4a557a77" width="390" alt="The popover at phone width, opening below the pet, with the NC Pet Styles row"> <img src="https://code.openneo.net/attachments/af3c1970-2c29-411d-b271-2a519f1763b7" width="390" alt="The outfit list at phone width, with the NC Pet Style row and its buttons showing"> </details> ## What changes for users - **No style worn:** the popover shows the expressions as before, then an **NC Pet Styles** row with the species' style count. It closes the popover and opens the styles search, with the cursor in the field (except on touch devices, where the keyboard would cover the grid). - **Style worn:** the popover shows that style instead of expressions, with **Change style** (to the search) and **Remove**, plus a note that styles come with their own expression. - **Outfit list:** an **NC Pet Style** group comes first while a style is worn. Its row isn't a toggle like item rows: its buttons are Change style, Remove, and More info (the token's item page, for named styles). - The Expressions and Styles tabs are gone. ## Under the hood - `WardrobePage` has a stable `browseStyles` callback, passed to the PosePicker (through `WardrobePreviewAndControls` and `OutfitControls`) and to `ItemsPanel`. If you're already in styles mode it keeps your text. It also bumps a `searchFocusRequest` counter that `ItemsAndSearchPanels` uses to focus the field. - The popover turns off `returnFocusOnClose` when it closes for this, or focus would bounce back to its button. - `StyleSelect` and its hover preview leave the PosePicker, and `matchesDefaultStyle` goes with it. - **Server:** the alt styles JSON includes `full_name`, for the outfit row's title. The controller spec checks it. ## Testing `yarn lint`, Prettier and the controller spec pass. In Chromium against a local server with public data: - [x] The NC Pet Styles row closes the popover, opens the styles search and focuses the field. - [x] Wearing a style shows the outfit row, and the popover shows the worn card, with "Change style" focused. - [x] Remove in the popover switches back to expressions, and the outfit row goes away. - [x] A `?style=` URL shows the outfit row and the worn card. - [x] Change style, from the outfit row or the popover, opens the styles search with the worn tile checked and the field focused, including when already in that mode. - [x] The outfit row has a normal cursor, and its buttons show on hover. - [x] Phone emulation: the popover and outfit row lay out as shown above. A fresh-eyes review pass found the outfit row looked clickable; that's fixed in the last commit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_014PWWczDoFB58ZYFZ68WxeS
From using it:

- Hovering was too eager: sliding across tiles on the way somewhere else
  previewed them. Now the mouse has to rest on a tile (within a few
  pixels) for 250ms, however slowly it's sliding. And after clicking a
  tile, jiggling the mouse on it doesn't preview it again.
- "nc" offers NC Pet Styles too, after Neocash items.
- Choosing NC Pet Styles after typing a phrase like "nostalgic pet style"
  removes the whole "pet style", not just "style".
- The "Previewing" pill doesn't show for the style that's already worn.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014PWWczDoFB58ZYFZ68WxeS
Fix two edge cases in style hover and suggestion phrase removal
All checks were successful
CI / rspec (pull_request) Successful in 1m52s
CI / deploy (pull_request) Has been skipped
3f1cf57dae
- Leaving a tile before the mouse rests on it (onto a group heading or
  the gap between tiles) cancels its pending preview, instead of
  previewing it a moment later anyway.
- Only the last word of the typed phrase can be partial, so picking NC
  Pet Styles after "back to pet" keeps "back to".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014PWWczDoFB58ZYFZ68WxeS
Now that NC Pet Styles have a home in search, the PosePicker doesn't need
its own Styles tab, which opened right over the pet you were previewing.

- With no style worn, the popover shows the expressions, then an "NC Pet
  Styles" row with the species' style count. The row closes the popover
  and opens the NC Pet Styles search, with the cursor in the field.
- With a style worn, the popover shows that style instead, with "Change
  style" (to the search) and "Remove", plus a note that styles come with
  their own expression.
- The outfit list starts with an "NC Pet Style" group when one is worn:
  the token's thumbnail, the style's full name, NC and Pet Style badges,
  and Change, Remove and More info actions.

For the full name ("Nostalgic Faerie Aisha"), the alt styles JSON now
includes `full_name`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014PWWczDoFB58ZYFZ68WxeS
Don't make the outfit list's style row look clickable
All checks were successful
CI / rspec (pull_request) Successful in 1m51s
CI / deploy (pull_request) Has been skipped
e8c360d07d
Unlike item rows, it isn't a toggle: only its action buttons do things.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014PWWczDoFB58ZYFZ68WxeS
armin-bot force-pushed claude/slim-pose-picker from e8c360d07d
All checks were successful
CI / rspec (pull_request) Successful in 1m51s
CI / deploy (pull_request) Has been skipped
to af385b9974
All checks were successful
CI / rspec (pull_request) Successful in 2m15s
CI / deploy (pull_request) Has been skipped
2026-11-18 09:44:33 -08:00
Compare
matchu scheduled this pull request to auto merge when all checks succeed 2026-11-18 09:44:55 -08:00
matchu merged commit b9b552d723 into main 2026-11-18 09:47:09 -08:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
OpenNeo/impress!42
No description provided.