Patch sanitize, omniauth, and msgpack security advisories #23

Merged
matchu merged 1 commit from armin-bot/impress:claude/sharp-maxwell-416oyt into main 2026-11-15 18:00:26 -08:00
Contributor

The weekly security watch held these 4 advisories as unreachable for us. The fixes are small, so this takes them anyway.

Changes

  • sanitize 7.0.0 → 7.0.2 (GHSA-599p-54q3-ff89, GHSA-mg79-gw37-jxx7). Our only call uses Sanitize::Config::BASIC, which neither affects.
  • omniauth 2.1.4 → 2.3.1 (GHSA-m27g-v28p-f9fx, Host header injection).
    • 2.2.0 is the minimum fix; 2.3 adds origin and redirect hardening on top.
    • 2.3's new per-sign-in session storage is opt-in per strategy, and omniauth_openid_connect doesn't opt in. So NeoPass keeps using omniauth.origin / omniauth.params as before.
    • 2.4.x is only a day old, so it waits for a later update (see the 14-day cooldown in the bundle update PR).
  • msgpack 1.8.0 → 1.8.7 (GHSA-73v3-wf97-vpgj, JRuby-only).
  • OmniAuth.config.full_host, set to the NeoPass redirect URI's origin (config/initializers/devise.rb).
    • OmniAuth 2.3 logs a Host-header warning on every login unless this or allowed_hosts is set.
    • NeoPass sends its hardcoded redirect_uri, not OmniAuth's callback_url, so this doesn't change its behavior.
    • Values: http://localhost:3000 in development, https://impress.openneo.net in production and with USE_LIVE_NEOPASS.
  • .bundler-audit.yml: removes the two entries these bumps fix (msgpack GHSA-4mrv-5p47-p938, sanitize GHSA-wgw9-qhqg-8hv5).

Testing

  • bundle exec rspec (422 examples) and bin/rails test pass.
  • bin/security-scan --osv is clear, with no stale ignores.
  • NeoPass works end to end against bin/neopass-server: sign-up, logout, then log back in twice. The Host-header warning doesn't appear in the log.

Merge this before the bundle update PR, which is stacked on it.

🤖 Generated with Claude Code

https://claude.ai/code/session_014PWWd1Ljyt9gAxzYFpJgJx

The weekly security watch held these 4 advisories as unreachable for us. The fixes are small, so this takes them anyway. ## Changes - **sanitize 7.0.0 → 7.0.2** (GHSA-599p-54q3-ff89, GHSA-mg79-gw37-jxx7). Our only call uses `Sanitize::Config::BASIC`, which neither affects. - **omniauth 2.1.4 → 2.3.1** (GHSA-m27g-v28p-f9fx, Host header injection). - 2.2.0 is the minimum fix; 2.3 adds origin and redirect hardening on top. - 2.3's new per-sign-in session storage is opt-in per strategy, and omniauth_openid_connect doesn't opt in. So NeoPass keeps using `omniauth.origin` / `omniauth.params` as before. - 2.4.x is only a day old, so it waits for a later update (see the 14-day cooldown in the `bundle update` PR). - **msgpack 1.8.0 → 1.8.7** (GHSA-73v3-wf97-vpgj, JRuby-only). - **`OmniAuth.config.full_host`**, set to the NeoPass redirect URI's origin (`config/initializers/devise.rb`). - OmniAuth 2.3 logs a Host-header warning on every login unless this or `allowed_hosts` is set. - NeoPass sends its hardcoded `redirect_uri`, not OmniAuth's `callback_url`, so this doesn't change its behavior. - Values: `http://localhost:3000` in development, `https://impress.openneo.net` in production and with `USE_LIVE_NEOPASS`. - **`.bundler-audit.yml`**: removes the two entries these bumps fix (msgpack GHSA-4mrv-5p47-p938, sanitize GHSA-wgw9-qhqg-8hv5). ## Testing - `bundle exec rspec` (422 examples) and `bin/rails test` pass. - `bin/security-scan --osv` is clear, with no stale ignores. - NeoPass works end to end against `bin/neopass-server`: sign-up, logout, then log back in twice. The Host-header warning doesn't appear in the log. Merge this before the `bundle update` PR, which is stacked on it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_014PWWd1Ljyt9gAxzYFpJgJx
Patch sanitize, omniauth, and msgpack security advisories
All checks were successful
CI / rspec (pull_request) Successful in 11m29s
CI / deploy (pull_request) Has been skipped
d5dc8a4b81
The security watch held these advisories as unreachable, but the fixes
are small, so take them anyway:

- sanitize 7.0.0 -> 7.0.2 (GHSA-599p-54q3-ff89, GHSA-mg79-gw37-jxx7).
  We only use Sanitize::Config::BASIC, which neither affects.
- omniauth 2.1.4 -> 2.3.1 (GHSA-m27g-v28p-f9fx, Host header injection).
  2.2.0 is the minimum fix; 2.3 adds origin and redirect hardening on
  top. Its new per-sign-in session storage is opt-in per strategy, and
  omniauth_openid_connect doesn't opt in, so NeoPass keeps using
  omniauth.origin and omniauth.params as before. (2.4.x is only a day
  old, so it waits for a later update.)
- msgpack 1.8.0 -> 1.8.7 (GHSA-73v3-wf97-vpgj, JRuby only).

OmniAuth 2.3 logs a warning about the Host header on every login unless
`OmniAuth.config.full_host` or `allowed_hosts` is set, so set full_host
to our NeoPass redirect URI's origin. NeoPass sends its hardcoded
redirect_uri rather than OmniAuth's callback_url, so this doesn't change
its behavior.

These also make two .bundler-audit.yml entries stale (msgpack's
GHSA-4mrv-5p47-p938, sanitize's GHSA-wgw9-qhqg-8hv5), so remove them.

Tested: rspec and rails test pass, bin/security-scan --osv is clear,
and a NeoPass sign-up, logout, and re-login against bin/neopass-server
works end to end, with no Host header warning in the log.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014PWWd1Ljyt9gAxzYFpJgJx
matchu merged commit af002de9f3 into main 2026-11-15 18:00:26 -08:00
matchu referenced this pull request from a commit 2026-11-15 19:06:47 -08:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
OpenNeo/impress!23
No description provided.