Add links to ~lebron petpage

Oh nice, we removed the last call site! Goodbye!

Gemfile

@@ -60,7 +60,6 @@ gem 'letter_opener', '~> 1.8', '>= 1.8.1', group: :development
 gem 'parallel', '~> 1.23'
 
 # For miscellaneous HTTP requests.
-gem "httparty", "~> 0.22.0"
 gem "addressable", "~> 2.8"
 
 # For advanced batching of many HTTP requests.

Gemfile.lock

@@ -133,7 +133,6 @@ GEM
       bigdecimal
       rexml
     crass (1.0.6)
-    csv (3.3.2)
     date (3.4.1)
     debug (1.9.2)
       irb (~> 1.10)
@@ -192,10 +191,6 @@ GEM
     hashdiff (1.1.2)
     hashie (5.0.0)
     http_accept_language (2.1.1)
-    httparty (0.22.0)
-      csv
-      mini_mime (>= 1.0.0)
-      multi_xml (>= 0.5.2)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     io-console (0.8.0)
@@ -245,8 +240,6 @@ GEM
     mini_portile2 (2.8.8)
     minitest (5.25.5)
     msgpack (1.7.5)
-    multi_xml (0.7.1)
-      bigdecimal (~> 3.1)
     mysql2 (0.5.6)
     net-http (0.6.0)
       uri
@@ -540,7 +533,6 @@ DEPENDENCIES
   falcon (~> 0.48.0)
   haml (~> 6.1, >= 6.1.1)
   http_accept_language (~> 2.1, >= 2.1.1)
-  httparty (~> 0.22.0)
   jsbundling-rails (~> 1.3)
   letter_opener (~> 1.8, >= 1.8.1)
   memory_profiler (~> 1.0)

app/views/items/_item_header.html.haml

@@ -33,9 +33,8 @@
       = link_to t('items.show.resources.jn_items'), jn_items_url_for(item)
       = link_to t('items.show.resources.impress_2020'), impress_2020_url_for(item)
       - if item.nc_trade_value
-        %span{
+        = link_to 'https://www.neopets.com/~lebron',
-          title: nc_trade_value_updated_at_text(item.nc_trade_value)
+          title: nc_trade_value_updated_at_text(item.nc_trade_value) do
-        }
           = t 'items.show.resources.lebron',
             value: nc_trade_value_estimate_text(item.nc_trade_value)
       - unless item.nc?

app/views/items/sources.html.haml

@@ -225,14 +225,14 @@
 					- content_for :subtitle, flush: true do
 						- if item.nc_trade_value.present?
 							- if nc_trade_value_is_estimate(item.nc_trade_value)
-								= content_tag :span,
+								= link_to 'https://www.neopets.com/~lebron', target: '_blank',
 									class: "nc-trade-guide-info-link",
 									title: 'Lebron keeps track of approximate "capsule" values of NC items for trading. Items with similar values can often be traded for one another. This is an estimate, not a rule!' do
 									%span.nc-trade-guide-info-label [Lebron]
 									Estimated value:
 									= nc_trade_value_estimate_text(item.nc_trade_value)
 							- else
-								= content_tag :span,
+								= link_to 'https://www.neopets.com/~lebron', target: '_blank',
 									class: "nc-trade-guide-info-link",
 									title: "Lebron keeps track of how to get certain special items, even when there isn't a clear NC trade estimate." do
 									%span.nc-trade-guide-info-label [Lebron]