Oops, stop cutting off items on list page!

Made a mistake when refactoring to extract ClosetList! It made the full list page only show the preview 😅
This commit is contained in:
Emi Matchu 2021-06-19 11:47:25 -07:00
parent eace28839e
commit cc4e1f611f
2 changed files with 14 additions and 6 deletions

View file

@ -134,6 +134,7 @@ export function ClosetList({
closetList, closetList,
isCurrentUser, isCurrentUser,
headingVariant = "list-item", headingVariant = "list-item",
maxNumItemsToShow = null,
}) { }) {
const { isSupportUser, supportSecret } = useSupport(); const { isSupportUser, supportSecret } = useSupport();
const toast = useToast(); const toast = useToast();
@ -350,12 +351,7 @@ export function ClosetList({
<ClosetListContents <ClosetListContents
closetList={closetList} closetList={closetList}
isCurrentUser={isCurrentUser} isCurrentUser={isCurrentUser}
// For default lists, we don't have a separate page, we just inline maxNumItemsToShow={maxNumItemsToShow}
// them all here. This is a less-nice experience, but it simplifies
// the single-list page a lot to not have to care, and for now we just
// kinda expect that people who care about trade lists enough will
// group them into lists so it's nbd! ^_^`
maxNumItemsToShow={!closetList.isDefaultList ? 14 : null}
/> />
</Box> </Box>
); );

View file

@ -265,6 +265,12 @@ function UserItemListsIndexPage() {
? "hidden" ? "hidden"
: "list-item" : "list-item"
} }
// For default lists, we don't have a separate page, we just
// inline them all here. This is a less-nice experience, but it
// simplifies the single-list page a lot to not have to care,
// and for now we just kinda expect that people who care about
// trade lists enough will group them into lists so it's nbd!
maxNumItemsToShow={!closetList.isDefaultList ? 14 : null}
/> />
))} ))}
</VStack> </VStack>
@ -292,6 +298,12 @@ function UserItemListsIndexPage() {
? "hidden" ? "hidden"
: "list-item" : "list-item"
} }
// For default lists, we don't have a separate page, we just
// inline them all here. This is a less-nice experience, but it
// simplifies the single-list page a lot to not have to care,
// and for now we just kinda expect that people who care about
// trade lists enough will group them into lists so it's nbd!
maxNumItemsToShow={!closetList.isDefaultList ? 14 : null}
/> />
))} ))}
</VStack> </VStack>