From cc4e1f611f93cf2485cf3022259182826d2911c8 Mon Sep 17 00:00:00 2001 From: Matchu Date: Sat, 19 Jun 2021 11:47:25 -0700 Subject: [PATCH] Oops, stop cutting off items on list page! MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Made a mistake when refactoring to extract ClosetList! It made the full list page only show the preview 😅 --- src/app/UserItemListPage.js | 8 ++------ src/app/UserItemListsIndexPage.js | 12 ++++++++++++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/app/UserItemListPage.js b/src/app/UserItemListPage.js index 5022323..37091cf 100644 --- a/src/app/UserItemListPage.js +++ b/src/app/UserItemListPage.js @@ -134,6 +134,7 @@ export function ClosetList({ closetList, isCurrentUser, headingVariant = "list-item", + maxNumItemsToShow = null, }) { const { isSupportUser, supportSecret } = useSupport(); const toast = useToast(); @@ -350,12 +351,7 @@ export function ClosetList({ ); diff --git a/src/app/UserItemListsIndexPage.js b/src/app/UserItemListsIndexPage.js index e1a6b12..9d694ff 100644 --- a/src/app/UserItemListsIndexPage.js +++ b/src/app/UserItemListsIndexPage.js @@ -265,6 +265,12 @@ function UserItemListsIndexPage() { ? "hidden" : "list-item" } + // For default lists, we don't have a separate page, we just + // inline them all here. This is a less-nice experience, but it + // simplifies the single-list page a lot to not have to care, + // and for now we just kinda expect that people who care about + // trade lists enough will group them into lists so it's nbd! + maxNumItemsToShow={!closetList.isDefaultList ? 14 : null} /> ))} @@ -292,6 +298,12 @@ function UserItemListsIndexPage() { ? "hidden" : "list-item" } + // For default lists, we don't have a separate page, we just + // inline them all here. This is a less-nice experience, but it + // simplifies the single-list page a lot to not have to care, + // and for now we just kinda expect that people who care about + // trade lists enough will group them into lists so it's nbd! + maxNumItemsToShow={!closetList.isDefaultList ? 14 : null} /> ))}