OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Oops, stop cutting off items on list page!

Browse source 
Made a mistake when refactoring to extract ClosetList! It made the full list page only show the preview 😅
This commit is contained in:
Emi Matchu 2021-06-19 11:47:25 -07:00
parent eace28839e
commit cc4e1f611f
2 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/app/UserItemListPage.js
View file

@ -134,6 +134,7 @@ export function ClosetList({
closetList,
isCurrentUser,
headingVariant = "list-item",
maxNumItemsToShow = null,
}) {
const { isSupportUser, supportSecret } = useSupport();
const toast = useToast();
@ -350,12 +351,7 @@ export function ClosetList({
<ClosetListContents
closetList={closetList}
isCurrentUser={isCurrentUser}
// For default lists, we don't have a separate page, we just inline
// them all here. This is a less-nice experience, but it simplifies
// the single-list page a lot to not have to care, and for now we just
// kinda expect that people who care about trade lists enough will
// group them into lists so it's nbd! ^_^`
maxNumItemsToShow={!closetList.isDefaultList ? 14 : null}
maxNumItemsToShow={maxNumItemsToShow}
/>
</Box>
);

12
src/app/UserItemListsIndexPage.js
View file

@ -265,6 +265,12 @@ function UserItemListsIndexPage() {
? "hidden"
: "list-item"
}
// For default lists, we don't have a separate page, we just
// inline them all here. This is a less-nice experience, but it
// simplifies the single-list page a lot to not have to care,
// and for now we just kinda expect that people who care about
// trade lists enough will group them into lists so it's nbd!
maxNumItemsToShow={!closetList.isDefaultList ? 14 : null}
/>
))}
</VStack>
@ -292,6 +298,12 @@ function UserItemListsIndexPage() {
? "hidden"
: "list-item"
}
// For default lists, we don't have a separate page, we just
// inline them all here. This is a less-nice experience, but it
// simplifies the single-list page a lot to not have to care,
// and for now we just kinda expect that people who care about
// trade lists enough will group them into lists so it's nbd!
maxNumItemsToShow={!closetList.isDefaultList ? 14 : null}
/>
))}
</VStack>