Add glitch OFFICIAL_MOVIE_IS_INCORRECT

Some of the "MiniMME11-S1: Approaching Eventide Skirt" visuals are pretty clearly glitched on TNT's end, like the Jubjub, which just has a single flat version of the dress floating in the corner of the screen.

This is a message to make that case even clearer!
This commit is contained in:
Emi Matchu 2021-04-12 19:51:19 -07:00
parent 1e4063f0d9
commit 3e3188786c
3 changed files with 34 additions and 0 deletions

View file

@ -73,6 +73,23 @@ function OutfitKnownGlitchesBadge({ appearance }) {
} }
} }
// Look for items with the OFFICIAL_MOVIE_IS_INCORRECT glitch.
for (const item of items) {
const itemHasGlitch = item.appearance.layers.some((l) =>
(l.knownGlitches || []).includes("OFFICIAL_MOVIE_IS_INCORRECT")
);
if (itemHasGlitch) {
glitchMessages.push(
<Box key={`official-movie-is-incorrect-for-item-${item.id}`}>
There's a glitch in the art for <i>{item.name}</i>, and we believe it
looks this way on-site, too. But our version might be out of date! If
you've seen it look better on-site, please email me at
matchu@openneo.net so we can fix it!
</Box>
);
}
}
// Look for items with the OFFICIAL_SVG_IS_INCORRECT glitch. // Look for items with the OFFICIAL_SVG_IS_INCORRECT glitch.
for (const item of items) { for (const item of items) {
const itemHasOfficialSvgIsIncorrect = item.appearance.layers.some((l) => const itemHasOfficialSvgIsIncorrect = item.appearance.layers.some((l) =>

View file

@ -442,6 +442,12 @@ function ItemLayerSupportKnownGlitchesFields({
(Will use the PNG instead) (Will use the PNG instead)
</Box> </Box>
</Checkbox> </Checkbox>
<Checkbox value="OFFICIAL_MOVIE_IS_INCORRECT">
Official Movie is incorrect{" "}
<Box display="inline" color="gray.400" fontSize="sm">
(Will display a message)
</Box>
</Checkbox>
<Checkbox value="DISPLAYS_INCORRECTLY_BUT_CAUSE_UNKNOWN"> <Checkbox value="DISPLAYS_INCORRECTLY_BUT_CAUSE_UNKNOWN">
Displays incorrectly, but cause unknown{" "} Displays incorrectly, but cause unknown{" "}
<Box display="inline" color="gray.400" fontSize="sm"> <Box display="inline" color="gray.400" fontSize="sm">

View file

@ -100,6 +100,17 @@ const typeDefs = gql`
# For affected layers, svgUrl will be null, regardless of the manifest. # For affected layers, svgUrl will be null, regardless of the manifest.
OFFICIAL_SVG_IS_INCORRECT OFFICIAL_SVG_IS_INCORRECT
# This glitch means that the official movie JS library (or supporting data)
# for this layer is known to contain a glitch.
#
# In this case, we _could_ fall back to the PNG, but we choose not to: it
# could mislead people about how the item will appear on-site. We like our
# previews to match the real on-site appearance whenever possible! Instead,
# we show a message, asking users to send us info if they know it to be
# fixed on-site. (This could happen by our manifest getting out of date, or
# TNT replacing it with a new asset that needs re-modeling.)
OFFICIAL_MOVIE_IS_INCORRECT
# This glitch means that we know the layer doesn't display correctly on # This glitch means that we know the layer doesn't display correctly on
# DTI, but we're not sure why, or whether it works differently on-site. We # DTI, but we're not sure why, or whether it works differently on-site. We
# show a vague apologetic message, asking users to send us info. # show a vague apologetic message, asking users to send us info.