From 3e3188786cbee89f0bbf9dbfd086acfdd4741f00 Mon Sep 17 00:00:00 2001
From: Matchu <matchu1993@gmail.com>
Date: Mon, 12 Apr 2021 19:51:19 -0700
Subject: [PATCH] Add glitch OFFICIAL_MOVIE_IS_INCORRECT

Some of the "MiniMME11-S1: Approaching Eventide Skirt" visuals are pretty clearly glitched on TNT's end, like the Jubjub, which just has a single flat version of the dress floating in the corner of the screen.

This is a message to make that case even clearer!
---
 .../WardrobePage/OutfitKnownGlitchesBadge.js    | 17 +++++++++++++++++
 .../support/ItemLayerSupportModal.js            |  6 ++++++
 src/server/types/AppearanceLayer.js             | 11 +++++++++++
 3 files changed, 34 insertions(+)

diff --git a/src/app/WardrobePage/OutfitKnownGlitchesBadge.js b/src/app/WardrobePage/OutfitKnownGlitchesBadge.js
index 5d99fa6..625f46f 100644
--- a/src/app/WardrobePage/OutfitKnownGlitchesBadge.js
+++ b/src/app/WardrobePage/OutfitKnownGlitchesBadge.js
@@ -73,6 +73,23 @@ function OutfitKnownGlitchesBadge({ appearance }) {
     }
   }
 
+  // Look for items with the OFFICIAL_MOVIE_IS_INCORRECT glitch.
+  for (const item of items) {
+    const itemHasGlitch = item.appearance.layers.some((l) =>
+      (l.knownGlitches || []).includes("OFFICIAL_MOVIE_IS_INCORRECT")
+    );
+    if (itemHasGlitch) {
+      glitchMessages.push(
+        <Box key={`official-movie-is-incorrect-for-item-${item.id}`}>
+          There's a glitch in the art for <i>{item.name}</i>, and we believe it
+          looks this way on-site, too. But our version might be out of date! If
+          you've seen it look better on-site, please email me at
+          matchu@openneo.net so we can fix it!
+        </Box>
+      );
+    }
+  }
+
   // Look for items with the OFFICIAL_SVG_IS_INCORRECT glitch.
   for (const item of items) {
     const itemHasOfficialSvgIsIncorrect = item.appearance.layers.some((l) =>
diff --git a/src/app/WardrobePage/support/ItemLayerSupportModal.js b/src/app/WardrobePage/support/ItemLayerSupportModal.js
index 18ea119..363bc45 100644
--- a/src/app/WardrobePage/support/ItemLayerSupportModal.js
+++ b/src/app/WardrobePage/support/ItemLayerSupportModal.js
@@ -442,6 +442,12 @@ function ItemLayerSupportKnownGlitchesFields({
               (Will use the PNG instead)
             </Box>
           </Checkbox>
+          <Checkbox value="OFFICIAL_MOVIE_IS_INCORRECT">
+            Official Movie is incorrect{" "}
+            <Box display="inline" color="gray.400" fontSize="sm">
+              (Will display a message)
+            </Box>
+          </Checkbox>
           <Checkbox value="DISPLAYS_INCORRECTLY_BUT_CAUSE_UNKNOWN">
             Displays incorrectly, but cause unknown{" "}
             <Box display="inline" color="gray.400" fontSize="sm">
diff --git a/src/server/types/AppearanceLayer.js b/src/server/types/AppearanceLayer.js
index 4e51cb2..094d0e3 100644
--- a/src/server/types/AppearanceLayer.js
+++ b/src/server/types/AppearanceLayer.js
@@ -100,6 +100,17 @@ const typeDefs = gql`
     # For affected layers, svgUrl will be null, regardless of the manifest.
     OFFICIAL_SVG_IS_INCORRECT
 
+    # This glitch means that the official movie JS library (or supporting data)
+    # for this layer is known to contain a glitch.
+    #
+    # In this case, we _could_ fall back to the PNG, but we choose not to: it
+    # could mislead people about how the item will appear on-site. We like our
+    # previews to match the real on-site appearance whenever possible! Instead,
+    # we show a message, asking users to send us info if they know it to be
+    # fixed on-site. (This could happen by our manifest getting out of date, or
+    # TNT replacing it with a new asset that needs re-modeling.)
+    OFFICIAL_MOVIE_IS_INCORRECT
+
     # This glitch means that we know the layer doesn't display correctly on
     # DTI, but we're not sure why, or whether it works differently on-site. We
     # show a vague apologetic message, asking users to send us info.