Emi Matchu matchu
matchu pushed to simpler-item-previews at OpenNeo/impress 2024-08-31 12:51:22 -07:00
5cbab5a766 Merge branch 'main' into simpler-item-previews
e67830642c Upgrade to Ruby 3.3.4 in production
1972ecf043 Use async instead of defer for analytics script
30e757b050 Add x86_64 versions of some of the cached gems
af8dd42830 Add better support for hashed pet names
Compare 8 commits »
matchu pushed to main at OpenNeo/impress 2024-08-31 12:49:59 -07:00
e67830642c Upgrade to Ruby 3.3.4 in production
matchu commented on pull request OpenNeo/impress#2 2024-08-31 12:18:24 -07:00
Add better support for hashed pet names on bulk modeler

Committed a modified version of this! Thank you!!

matchu closed pull request OpenNeo/impress#2 2024-08-31 12:18:24 -07:00
Add better support for hashed pet names on bulk modeler
matchu pushed to main at OpenNeo/impress 2024-08-31 12:15:37 -07:00
1972ecf043 Use async instead of defer for analytics script
30e757b050 Add x86_64 versions of some of the cached gems
af8dd42830 Add better support for hashed pet names
Compare 3 commits »
matchu commented on pull request OpenNeo/impress#2 2024-08-30 18:05:44 -07:00
Add better support for hashed pet names on bulk modeler

Ohhh ok so, this section is a bit tricky, because the templating here isn't actually HAML, it's jquery/tmpl. The ${} stuff isn't expanded at HTML generation time, it's included in the HTML and then the JS uses that as a template later.

matchu suggested changes for OpenNeo/impress#2 2024-08-30 18:05:44 -07:00
Add better support for hashed pet names on bulk modeler

Idk Github-style flows for this, I'm marking this "Request changes" but I can probably attend to the changes myself later—I also don't know how that works in PR style though, like, can I add my own commits to this? Or is the style more like, I would branch off this PR into one of my own? Or something?

matchu pushed to enhance-hashed-pets at dice/impress 2024-08-30 17:57:58 -07:00
e80a49a086 Add better support for hashed pet names
04ffc30e92 Remove SSW link, does not work on neopets anymore
Compare 2 commits »
matchu pushed to main at OpenNeo/impress 2024-08-30 17:38:31 -07:00
04ffc30e92 Remove SSW link, does not work on neopets anymore
matchu merged pull request OpenNeo/impress#1 2024-08-30 17:38:30 -07:00
Remove SSW link, does not work on neopets anymore
matchu pushed to main at OpenNeo/impress 2024-08-30 17:37:35 -07:00
matchu commented on pull request OpenNeo/impress#1 2024-08-30 17:37:16 -07:00
Remove SSW link, does not work on neopets anymore

I'm actually gonna rewind and do it from here, cuz having it be marked correctly as Merged will please me. Idk what I'm missing re doing it from vanilla git (maybe it just Works This Way and…

matchu reopened pull request OpenNeo/impress#1 2024-08-30 17:35:56 -07:00
Remove SSW link, does not work on neopets anymore
matchu commented on pull request OpenNeo/impress#1 2024-08-30 17:35:13 -07:00
Remove SSW link, does not work on neopets anymore

Huh I followed the instructions to merge this from the command line, and I had hoped it would connect it back to the PR but I guess it didn't. Anyway, it's in there, so!

matchu closed pull request OpenNeo/impress#1 2024-08-30 17:34:45 -07:00
Remove SSW link, does not work on neopets anymore
matchu pushed to main at OpenNeo/impress 2024-08-30 17:34:38 -07:00
04ffc30e92 Remove SSW link, does not work on neopets anymore
matchu commented on pull request OpenNeo/impress#1 2024-08-30 17:34:26 -07:00
Remove SSW link, does not work on neopets anymore

Ohhh yes this seems to work good thank you!!

I imagine you tried this too (cuz you were so thorough thank you!!!), but for good measure I searched the codebase for "super" and \bssw\b and…

matchu pushed to simpler-item-previews at OpenNeo/impress 2024-08-30 17:09:58 -07:00
8ad0025e32 A few more comments and code style refactors for item previews
matchu pushed to main at OpenNeo/impress 2024-08-27 17:06:32 -07:00
acade360a8 Update Ruby to 3.3.4, and update gems
matchu pushed to main at OpenNeo/openneo-analytics 2024-08-27 12:36:05 -07:00
6548666b95 Change db volume version, and add hints to upgrade it in the future