async
instead of defer
for analytics script
Committed a modified version of this! Thank you!!
async
instead of defer
for analytics script
Ohhh ok so, this section is a bit tricky, because the templating here isn't actually HAML, it's jquery/tmpl
. The ${}
stuff isn't expanded at HTML generation time, it's included in the HTML and then the JS uses that as a template later.
Idk Github-style flows for this, I'm marking this "Request changes" but I can probably attend to the changes myself later—I also don't know how that works in PR style though, like, can I add my own commits to this? Or is the style more like, I would branch off this PR into one of my own? Or something?
I'm actually gonna rewind and do it from here, cuz having it be marked correctly as Merged will please me. Idk what I'm missing re doing it from vanilla git (maybe it just Works This Way and…
Huh I followed the instructions to merge this from the command line, and I had hoped it would connect it back to the PR but I guess it didn't. Anyway, it's in there, so!
Ohhh yes this seems to work good thank you!!
I imagine you tried this too (cuz you were so thorough thank you!!!), but for good measure I searched the codebase for "super" and \bssw\b
and…