1
0
Fork 0
forked from OpenNeo/impress
impress/app
Matt Dunn-Rankin f54683464f stop appending ?NO_CAMO_CONFIG when image proxying is disabled
One time I did a thing called Camo to try to get our HTTPS pages working,
because images.neopets.com not supporting HTTPS is crazy >_> I've diasbled it
these days, but it had debug behavior to append `?NO_CAMO_CONFIG` to all
proxied URLs when Camo was not configured.

When an item had no thumbnail URL for some reason (mall spider needs fixing,
maybe?), this caused Rails to try to map that empty string into the path
`/assets/?NO_CAMO_CONFIG`, which made Rails complain that it was trying to load
an asset that doesn't exist. This is probably a sign that using `image_tag` for
URLs that *should* be external URLs, but aren't strictly *guaranteed* to be, is
unwise - but, for now, I've just disabled that behavior. I hope Rails has a
better escape hatch for the empty string :P
2017-04-01 10:04:54 -07:00
..
assets whoops, dont trigger autofilter checkbox if we *only* collapsed spaces 2017-01-09 11:16:42 -08:00
controllers donation error handling 2017-01-07 19:19:44 -08:00
flex advanced search by pet type fit :) 2014-04-05 18:48:20 -05:00
helpers update campaign final stretch copy 2017-01-09 11:35:55 -08:00
mailers donation mailer 2014-09-10 14:32:54 -05:00
models stop appending ?NO_CAMO_CONFIG when image proxying is disabled 2017-04-01 10:04:54 -07:00
views ooof, got the amount wrong D: 2017-01-05 18:52:08 -08:00