1
0
Fork 0
forked from OpenNeo/impress
impress/app/controllers
Emi Matchu 95c1a4f391 Fix bugs in Settings page when changes to the model are incomplete
Ahh okay tricky lil thing: if you show the settings page with a partial
change to `AuthUser` that didn't get saved, it can throw off the state
of some stuff. For example, if you don't have a password yet, then
enter a new password but leave the confirmation box blank, then you'll
correctly see "Password confirmation can't be blank", but you'll *also*
then be prompted for your "Current password", even though you don't
have one yet, because `@auth_user.uses_password?` is true now.

In this change, we extend the Settings form to use two copies of the
`AuthUser`. One is the copy with changes on it, and the other is the
"persisted" copy, which we check for parts of the UI that care about
what's actually saved, vs form state.
2024-04-09 06:34:06 -07:00
..
devise Connect a NeoPass to an existing account 2024-04-08 05:33:58 -07:00
fundraising Move most fundraising files into a Fundraising module 2024-02-18 20:12:14 -08:00
about_controller.rb Add first draft of /about/neopass page 2024-03-12 17:58:44 -07:00
alt_styles_controller.rb Read known_glitches when loading alt styles SWF assets 2024-02-24 16:31:05 -08:00
application_controller.rb Oh right, hide NeoPass on settings page unless you set the magic param! 2024-04-08 05:34:47 -07:00
auth_users_controller.rb Fix bugs in Settings page when changes to the model are incomplete 2024-04-09 06:34:06 -07:00
closet_hangers_controller.rb High-level caching for closet lists 2024-02-20 18:43:39 -08:00
closet_lists_controller.rb Use flash[:notice] instead of flash[:success] 2023-10-23 19:05:07 -07:00
contributions_controller.rb Migrate away from item translations in contributions 2024-02-20 15:52:10 -08:00
item_appearances_controller.rb Load item page restricted zones data from Rails app, not impress-2020 2023-11-11 08:49:19 -08:00
item_trades_controller.rb Oops, load the data for the bulk item quantity form on the trades page! 2024-01-21 06:42:24 -08:00
items_controller.rb Oops, fix redirect to item thumbnail 2024-03-12 18:45:05 -07:00
locales_controller.rb locale cookie should be long-term, not a session cookie 2013-01-11 11:48:40 -06:00
neopass_connections_controller.rb Oops, fix a redirect URL I missed when ejecting from Devise controller 2024-04-08 04:32:34 -07:00
neopets_connections_controller.rb closet hangers index uses neopets connections dropdown 2014-01-18 22:50:14 -06:00
neopets_page_import_tasks_controller.rb Fix petpage etc import 2023-11-06 12:59:28 -08:00
outfits_controller.rb Hack to speed up loading the homepage 2024-03-13 13:51:28 -07:00
pet_types_controller.rb Remove unused /colors/pet_types route 2024-02-24 15:51:40 -08:00
pets_controller.rb Migrate away from item translations in misc pages 2024-02-20 15:53:56 -08:00
sitemap_controller.rb Migrate away from item translations in misc pages 2024-02-20 15:53:56 -08:00
users_controller.rb Use flash[:notice] instead of flash[:success] 2023-10-23 19:05:07 -07:00