1
0
Fork 0
forked from OpenNeo/impress
impress/app
Emi Matchu 1e99376449 Remove hundreds of unnecessary queries from /alt-styles page!
I think the Rails query cache handled these anyway? But `SwfAsset` has
a `before_save` hook that checks its zone's info, and
`SwfAsset.preload_manifests` saves all the assets, on the assumption
that saving is a no-op when the record didn't change anyway. And it
basically is!

But I figure that, now that I'm realizing hooks exist, simply not
attempting to save unchanged records is probably a better
representation of what we intend to do. So I'm fixing it like that!

Another potential fix would be to preload the zones for these assets,
but I think that confuses the intent too much; the method itself isn't
using the zones, it's just a weird incidental thing that a save hook
happens to use. (Would probably be better to refactor this old save
hook into a different situation altogether, but that's for another
time!)
2024-05-29 18:52:36 -07:00
..
assets Don't let action buttons wrap onto multiple lines in Item Getting Guide 2024-05-28 17:16:41 -07:00
controllers Preload SWF asset manifests during wardrobe item search 2024-05-28 17:05:04 -07:00
helpers Add OWLS values to non-NC-Mall NC items in Item Getting Guide 2024-05-27 15:53:08 -07:00
javascript Improve layout for "Get these items!" and "Save" buttons in editor 2024-05-28 17:32:18 -07:00
mailers/fundraising Move most fundraising files into a Fundraising module 2024-02-18 20:12:14 -08:00
models Remove hundreds of unnecessary queries from /alt-styles page! 2024-05-29 18:52:36 -07:00
services Load *all* NC Mall pages in nc_mall:sync 2024-05-10 17:39:40 -07:00
views Remove outdated info from Alt Styles page 2024-05-29 18:47:06 -07:00