1
0
Fork 0
forked from OpenNeo/impress
impress/app
Emi Matchu a3bd841bb8 Fix handling of basic PB items in Item Getting Guide
Okay so, like 30 minutes ago I added fallback behavior for cases where
we can't correctly infer the color from a PB item's name… and then I
pulled it up in the color and found that, oh, right, there are already
3 PB items that *correctly* return `nil` for `Item#pb_color`: Aisha
Collar, Elephante Hat, and Ixi Collar.

This is because they're common items that apply to many colors, like
the basics, but also many other less-special or older color variants.
They are the most likely case where we'll return `nil`.

So, I've updated our fallback UI to, instead of talk vaguely about
missing data, just assume that we're dealing with basic items. In the
rare window of time where a new color is released, and we have PB items
for it but no manual color data yet, this can just incorrectly say
"Basic Colors" and that's fine.
2024-06-05 19:45:39 -07:00
..
assets Don't let action buttons wrap onto multiple lines in Item Getting Guide 2024-05-28 17:16:41 -07:00
controllers Handle newly-released PB items in Item Getting Guide 2024-06-05 19:23:57 -07:00
helpers Add OWLS values to non-NC-Mall NC items in Item Getting Guide 2024-05-27 15:53:08 -07:00
javascript Redesign "Get these items!" button to use a cart icon instead 2024-05-31 17:38:25 -07:00
mailers/fundraising Move most fundraising files into a Fundraising module 2024-02-18 20:12:14 -08:00
models Handle newly-released species in Item Getting Guide 2024-06-05 19:27:38 -07:00
services Load *all* NC Mall pages in nc_mall:sync 2024-05-10 17:39:40 -07:00
views Fix handling of basic PB items in Item Getting Guide 2024-06-05 19:45:39 -07:00