forked from OpenNeo/impress
Dress to Impress, a big fancy Neopets customization tool!
Emi Matchu
9d8f035360
Ahh, we recently added a step to pet loading that sends a metadata request to `PetService.getPet`, which is now (in a sense, correctly!) raising a `PetNotFound` error when we try modeling with a "pet" that starts with `@` (a trick we use in situations where we can get an image hash for a modeling situation, but not an irl pet itself). In this change, we make it no longer a crashing issue if the pet metadata request fails: it's not a big deal to have a `PetType` have no image hash or not have it be up-to-date! In the next change, I'll also add an optimization to skip fetching it altogether in this case—but I wanted to see this work first, because the more general resilience is more important imo! |
||
|---|---|---|
| .devcontainer | ||
| .husky | ||
| app | ||
| bin | ||
| config | ||
| db | ||
| deploy | ||
| lib | ||
| public | ||
| test | ||
| vendor | ||
| .eslintrc.json | ||
| .gitignore | ||
| .ruby-version | ||
| .yarnrc.yml | ||
| config.ru | ||
| falcon.rb | ||
| Gemfile | ||
| Gemfile.lock | ||
| LICENSE.md | ||
| package.json | ||
| Procfile.dev | ||
| Rakefile | ||
| README.md | ||
| yarn.lock | ||
Dress to Impress
Oh! We've been revitalizing the Rails app! Fun!
There'll be more to say about it here soon :3