forked from OpenNeo/impress
Matchu
96998643b5
Ok so, impress-2020 guesses the manifest URL every time based on common URL patterns. But the right way to do this is to read it from the modeling data! But also, we don't have a great way to get the modeling data directly. (Though as I write this, I guess we do have that auto-modeling trick we use in the DTI 2020 codebase, I wonder if that could work for this too?) So anyway, in this change, we update the modeling code to save the manifest URL, and also the migration includes a big block that attempts to run impress-2020's manifest-guessing logic for every asset and save the result! It's uhh. Not fast. It runs at about 1 asset per second (a lot of these aren't cache hits), and sometimes stalls out. And we have >600k assets, so the estimated wall time is uhh. Seven days? I think there's something we could do here around like, concurrent execution? Though tbqh with the nature of the slowness being seemingly about hitting the slow underlying images.neopets.com server, I don't actually have a lot of faith that concurrency would actually be faster? I also think it could be sensible to like… extract this from the migration, and run it as a script to infer missing manifest URLs. That would be easier to run in chunks and resume if something goes wrong. Cuz like, I think my reasoning here was that backfilling this data was part of the migration process… but the thing is, this migration can't reliably get a manifest for everything (both cuz it depends on an external service and cuz not everything has one), so it's a perfectly valid migration to just leave the column as null for all the rows to start, and fill this in later. I wish I'd written it like that! But anyway, I'm just running this for now, and taking a break for the night. Maybe later I'll come around and extract this into a separate task to just try this on all assets missing manifests instead!
55 lines
2 KiB
Ruby
55 lines
2 KiB
Ruby
class AddManifestUrlToSwfAssets < ActiveRecord::Migration[7.1]
|
|
def change
|
|
add_column :swf_assets, :manifest_url, :string
|
|
|
|
# Okay, this is a big one to run upward! We're going to infer the manifest
|
|
# for as many assets as we can!
|
|
reversible do |direction|
|
|
direction.up do
|
|
Net::HTTP.start("images.neopets.com", 443, use_ssl: true) do |http|
|
|
SwfAsset.find_each do |swf_asset|
|
|
begin
|
|
manifest_url = infer_manifest_url(http, swf_asset.url)
|
|
rescue StandardError => error
|
|
Rails.logger.warn "Could not infer manifest URL for #{swf_asset.id}, skipping: #{error.message}"
|
|
next
|
|
end
|
|
|
|
Rails.logger.info "#{swf_asset.id}: #{manifest_url}"
|
|
swf_asset.manifest_url = manifest_url
|
|
swf_asset.save!
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
SWF_URL_PATTERN = %r{^(?:https?:)?//images\.neopets\.com/cp/(bio|items)/swf/(.+?)_([a-z0-9]+)\.swf$}
|
|
def infer_manifest_url(http, swf_url)
|
|
url_match = swf_url.match(SWF_URL_PATTERN)
|
|
raise ArgumentError, "not a valid SWF URL: #{swf_url}" if url_match.nil?
|
|
|
|
# Build the potential manifest URLs, from the two structures we know of.
|
|
type, folders, hash_str = url_match.captures
|
|
potential_manifest_urls = [
|
|
"https://images.neopets.com/cp/#{type}/data/#{folders}/manifest.json",
|
|
"https://images.neopets.com/cp/#{type}/data/#{folders}_#{hash_str}/manifest.json",
|
|
]
|
|
|
|
# Send a HEAD request to test each manifest URL, without downloading its
|
|
# content. If it succeeds, we're done!
|
|
potential_manifest_urls.each do |potential_manifest_url|
|
|
res = http.head potential_manifest_url
|
|
if res.is_a? Net::HTTPOK
|
|
return potential_manifest_url
|
|
elsif res.is_a? Net::HTTPNotFound
|
|
next
|
|
else
|
|
raise "unexpected manifest response code: #{res.code}"
|
|
end
|
|
end
|
|
|
|
# Otherwise, there's no valid manifest URL.
|
|
raise "none of the common manifest URL patterns returned HTTP 200"
|
|
end
|
|
end
|