1
0
Fork 0
forked from OpenNeo/impress
impress/app
Matchu 96998643b5 Add manifest_url to swf_assets table
Ok so, impress-2020 guesses the manifest URL every time based on common
URL patterns. But the right way to do this is to read it from the
modeling data! But also, we don't have a great way to get the modeling
data directly. (Though as I write this, I guess we do have that
auto-modeling trick we use in the DTI 2020 codebase, I wonder if that
could work for this too?)

So anyway, in this change, we update the modeling code to save the
manifest URL, and also the migration includes a big block that attempts
to run impress-2020's manifest-guessing logic for every asset and save
the result!

It's uhh. Not fast. It runs at about 1 asset per second (a lot of these
aren't cache hits), and sometimes stalls out. And we have >600k assets,
so the estimated wall time is uhh. Seven days?

I think there's something we could do here around like, concurrent
execution? Though tbqh with the nature of the slowness being seemingly
about hitting the slow underlying images.neopets.com server, I don't
actually have a lot of faith that concurrency would actually be faster?

I also think it could be sensible to like… extract this from the
migration, and run it as a script to infer missing manifest URLs. That
would be easier to run in chunks and resume if something goes wrong.
Cuz like, I think my reasoning here was that backfilling this data was
part of the migration process… but the thing is, this migration can't
reliably get a manifest for everything (both cuz it depends on an
external service and cuz not everything has one), so it's a perfectly
valid migration to just leave the column as null for all the rows to
start, and fill this in later. I wish I'd written it like that!

But anyway, I'm just running this for now, and taking a break for the
night. Maybe later I'll come around and extract this into a separate
task to just try this on all assets missing manifests instead!
2023-11-09 21:42:51 -08:00
..
assets Remove "Import from pets" page 2023-11-06 13:06:18 -08:00
controllers Remove "Import from pets" page 2023-11-06 13:06:18 -08:00
helpers Add Owls values to the item page 2023-11-03 16:20:02 -07:00
javascript Fix outfit saving infinite loop in error case 2023-11-06 12:54:23 -08:00
mailers donation mailer 2014-09-10 14:32:54 -05:00
models Add manifest_url to swf_assets table 2023-11-09 21:42:51 -08:00
services Add Owls values to the item page 2023-11-03 16:20:02 -07:00
views Remove "Import from pets" page 2023-11-06 13:06:18 -08:00