1
0
Fork 0
forked from OpenNeo/impress
impress/app/models
Emi Matchu 522287ed53 Fix MissingAttributeError in ClosetHanger#merge_quantities
Oh rough, when moving an item list entry from one list to another, our
logic to merge their quantities if it's already in that list was just
fully crashing!

That is, moves without anything to merge were working, but moves that
required a merge were raising Internal Server Error 500, because the
`list_id` attribute wasn't present.

I'm not sure why this ever worked, I'm assuming using `list_id` in the
`where` condition would include it in the `select` implicitly in a
previous version of Rails? Or maybe Rails used to have fallback
behavior to run a second query, instead of raising
`MissingAttributeError` like it does now?

Well, in any case, this seems to fix it! Whew!
2024-02-28 13:30:55 -08:00
..
fundraising
item Use fits:nostalgic-faerie-draik filter format when we can 2024-02-27 15:51:27 -08:00
alt_style.rb
application_record.rb Upgrade to Rails 5.2.8.1 2023-10-23 19:05:05 -07:00
auth_record.rb Add AuthUser model, connecting to openneo_id db 2023-10-23 19:05:07 -07:00
auth_user.rb Clarify the error behavior on AuthUser syncing 2023-10-23 19:05:08 -07:00
closet_hanger.rb
closet_list.rb Migrate away from item translations in the Your Items feature 2024-02-20 15:36:20 -08:00
closet_visibility.rb Delete a couple unused accessors 2023-11-11 15:42:08 -08:00
color.rb
contribution.rb
item.rb Filter search in wardrobe-2020 by alt styles! 2024-02-27 16:11:06 -08:00
item_outfit_relationship.rb
neopets_connection.rb Upgrade to Rails 5.2.8.1 2023-10-23 19:05:05 -07:00
neopets_page.rb Update most URLs to use HTTPS 2023-10-25 15:22:57 -07:00
outfit.rb Refactor Impress 2020 config 2024-02-22 13:07:43 -08:00
parent_swf_asset_relationship.rb
pet.rb
pet_state.rb Remove logic to auto-detect Unconverted pets (fixes Baby Pteri bug) 2024-02-01 01:40:50 -08:00
pet_type.rb Filter search in wardrobe-2020 by alt styles! 2024-02-27 16:11:06 -08:00
species.rb
swf_asset.rb Fix crash when dealing with 404'd manifests 2024-02-25 16:05:43 -08:00
user.rb
zone.rb Add useItemSearch for wardrobe app, but don't use it yet! 2024-02-25 12:06:32 -08:00