forked from OpenNeo/impress
Emi Matchu
bc8d265672
According to our GlitchTip error tracker, every time we deploy, a couple instances of `Async::Stop` and `Async::Container::Terminate` come in, presumably because: 1. systemd sends a STOP signal to the `falcon host` process. 2. `falcon host` gives the in-progress requests some time to finish up 3. Sometimes some requests take too long, and so something happens. (either a timer in Falcon or a KILL signal from systemd, not sure!) that leads the ongoing requests to finally be terminated by raising an `Async::Stop` or `Async::Container::Terminate`. (I'm not sure when each happens, and maybe they happen at different points in the process? Maybe one happens for the actual long-running ones, vs the other happens if more requests come in during the meantime but get caught in the spin-down process?) 4. Rails bubbles up the errors, our Sentry library notices them and sends them to GlitchTip, the user presumably receives the generic 500 error, and the app can finally close down gracefully. It's hard for me to validate that this is *exactly* what's happening here or that my mitigation makes sense, but my logic here is basically, if these exceptions are bubbling up as "uncaught exceptions" and spamming up our error log, then the best solution would be to catch them! So in this change, we add an error handler for these two error classes, which hopefully will 1) give users a better experience when this happens, and 2) no longer send these errors to our logging 🤞❗️ That strange phenomenon where the best way to get a noisy bug out of your logs is to fix it lmao |
||
|---|---|---|
| .. | ||
| fundraising | ||
| alt_styles_controller.rb | ||
| application_controller.rb | ||
| closet_hangers_controller.rb | ||
| closet_lists_controller.rb | ||
| contributions_controller.rb | ||
| item_appearances_controller.rb | ||
| item_trades_controller.rb | ||
| items_controller.rb | ||
| locales_controller.rb | ||
| neopets_connections_controller.rb | ||
| neopets_page_import_tasks_controller.rb | ||
| outfits_controller.rb | ||
| pet_types_controller.rb | ||
| pets_controller.rb | ||
| sitemap_controller.rb | ||
| static_controller.rb | ||
| users_controller.rb | ||