1
0
Fork 0
forked from OpenNeo/impress
impress/.devcontainer
Matchu 6bbef7e75e Move the host: db part of the dev container into its environment vars
Okay, so I've kept `database.yml` using the new username and password
`impress_dev`, cuz I like that it helps clarify that it's dev stuff and
is impossible to confuse with prod. (I updated my local setup to match!)

But hardcoding `host: db` into here breaks my local setup where the
database _isn't_ at the hostname `db`. So I add a way for new optional
database URL environment variables to get merged in with these settings,
and then configured the dev container to use that—and just in the most
limited override possible, to avoid duplicating stuff we don't need to.
(I could've just used the same names `DATABASE_URL_{PRIMARY,OPENNEO_ID}`
for this, but idk, I think it's confusing to have the same one for both
dev and prod, even though Rails _does_ basically do this; see below.)

Normally, the environment variable `DATABASE_URL` just _does_ this, and
you don't need to include a `url` key at all to get this behavior. But
since we've got the legacy two-database thing going on, we do this
instead! If we were to merge the `openneo_id.users` table into the
primary database, we could simplify this!
2023-10-26 14:20:15 -07:00
..
create-db.sql [WIP] Build a dev container 2023-10-25 11:46:14 -07:00
devcontainer.json Move the host: db part of the dev container into its environment vars 2023-10-26 14:20:15 -07:00
docker-compose.yml [WIP] Build a dev container 2023-10-25 11:46:14 -07:00
Dockerfile [WIP] Build a dev container 2023-10-25 11:46:14 -07:00
post-create.sh Oops, fix bugs in dev container setup! 2023-10-26 00:04:20 +00:00