1
0
Fork 0
forked from OpenNeo/impress
impress/app/models
Matt Dunn-Rankin 6697b15413 More generously catch errors on userlookup
Okay so, userlookup stuff hasn't worked in years, because it requires a login now.

But apparently, somewhere recently, the code inside our `neopets` gem started hard crashing, because of assumptions we made about the document we'd get back.

I'm not sure why it only recently started crashing? or if I'm even necessarily right about that?

But anyway, I'm just doing the easiest safest (🤞🏻) change possible: being more generous with the errors we swallow.

Test Plan:
Deploy and cross fingers.
2019-10-27 14:24:21 -07:00
..
item oh dang, did we just fix most of the mixed content? 2015-08-05 20:11:08 -04:00
asset_image_conversion_request.rb timeout on background jobs 2012-11-04 12:01:03 -06:00
campaign.rb thank-you message automatically deploys on campaign success 2015-09-22 22:40:51 -07:00
closet_group.rb import items to a specific list 2013-04-09 15:50:33 -05:00
closet_hanger.rb oh huh. looks like remove/move are ready. 2015-09-26 19:55:09 -07:00
closet_hanger_observer.rb oh poo, didn't commit these properly with the closet hanger caching :( 2013-12-27 21:48:38 -05:00
closet_list.rb refactor importing 2015-07-27 13:25:24 -04:00
closet_list_observer.rb oh poo, didn't commit these properly with the closet hanger caching :( 2013-12-27 21:48:38 -05:00
closet_visibility.rb Cache trade info on items#show, finally! I think it's the performance culprit. 2013-12-27 14:49:46 -05:00
color.rb lolwhoops, measure prank-funniness in PST 2014-04-01 19:10:44 -05:00
contribution.rb phew, fixed some issues with contribution saving in rails 3.2 2013-03-05 20:51:24 -06:00
contribution_observer.rb i18n for items#show (including javascripts/items/show.js) 2013-01-24 18:23:19 -06:00
donation.rb yum, we accept bitcoin! 2014-12-23 23:22:15 -05:00
donation_feature.rb stop breaking on donations that delete their outfit 2015-02-25 13:42:35 -06:00
fragment_expiration.rb only send cache deletions for usable locales 2013-12-08 23:44:25 -06:00
fragment_localization.rb i18n for outfits#new (and layouts#application), including caching 2013-01-24 18:23:18 -06:00
image.rb stop appending ?NO_CAMO_CONFIG when image proxying is disabled 2017-04-01 10:04:54 -07:00
item.rb Add db field to override special color 2018-05-09 14:10:20 -07:00
item_observer.rb Cache trade info on items#show, finally! I think it's the performance culprit. 2013-12-27 14:49:46 -05:00
item_outfit_relationship.rb lovely interface for saving outfits. still no reading them yet 2010-11-10 16:59:54 -05:00
neopets_connection.rb store all neopets usernames for logged-in users, but breaks closet_hangers#index 2014-01-18 21:55:01 -06:00
neopets_page.rb import from gallery 2015-07-28 15:05:40 -04:00
neopets_user.rb update NeopetsUser TODOs 2015-07-27 19:37:29 -04:00
news_post.rb news posts read from the database, with a campaign-supplement classname option :) 2015-09-26 20:37:03 -07:00
outfit.rb add prank messages to outfits#show 2014-03-28 15:15:04 -05:00
outfit_image_update.rb timeout on background jobs 2012-11-04 12:01:03 -06:00
outfit_image_uploader.rb use openneo-uploads bucket 2012-07-31 11:42:27 -04:00
parent_swf_asset_relationship.rb give SWFs real, unique ID numbers 2012-01-12 17:17:59 -06:00
pet.rb stop crashing when trying to translate item names 2015-07-27 13:23:46 -04:00
pet_attribute.rb capitalize each word of a species/color name (for Swamp Gas) 2011-07-12 18:22:16 -04:00
pet_state.rb More generously catch errors on userlookup 2019-10-27 14:24:21 -07:00
pet_type.rb prefer scraped rainbow pool images over pet images 2015-09-05 18:48:41 +00:00
pet_type_observer.rb cache pet images on items#show, in case that's what's being a super-slow jerkface 2013-12-05 15:22:43 -06:00
pretty_param.rb parameterize user params like items, plus a cleaner parameterization scheme 2011-07-26 18:49:52 -04:00
roulette.rb species check was in the wrong place. fixed 2011-01-27 17:50:08 -05:00
species.rb better handle new colors and species 2013-02-15 23:57:06 -06:00
static_resource.rb attempt to fix new species_support_ids format. sigh. 2013-01-23 00:25:09 -06:00
swf_asset.rb ugh, one more bug fix? 2017-10-29 15:18:53 -07:00
user.rb finally let people remove all items from the list at once. 2015-07-19 12:35:49 -04:00
user_sweeper.rb Cache trade info on items#show, finally! I think it's the performance culprit. 2013-12-27 14:49:46 -05:00
wardrobe_tip.rb basic tip functionality 2014-04-02 23:00:50 -05:00
zone.rb fix the necklace/collar advanced search bug! 2015-09-24 19:51:45 -07:00