1
0
Fork 0
forked from OpenNeo/impress
impress/app
Emi Matchu 522287ed53 Fix MissingAttributeError in ClosetHanger#merge_quantities
Oh rough, when moving an item list entry from one list to another, our
logic to merge their quantities if it's already in that list was just
fully crashing!

That is, moves without anything to merge were working, but moves that
required a merge were raising Internal Server Error 500, because the
`list_id` attribute wasn't present.

I'm not sure why this ever worked, I'm assuming using `list_id` in the
`where` condition would include it in the `select` implicitly in a
previous version of Rails? Or maybe Rails used to have fallback
behavior to run a second query, instead of raising
`MissingAttributeError` like it does now?

Well, in any case, this seems to fix it! Whew!
2024-02-28 13:30:55 -08:00
..
assets Oops, fix regression of editor features on item lists page 2024-02-22 15:52:40 -08:00
controllers Fix AccessDenied error handler 2024-02-28 13:20:41 -08:00
helpers Refactor Impress 2020 config 2024-02-22 13:07:43 -08:00
javascript Add "Baby Body Paint" warning to Known Glitches badge in-app, too 2024-02-27 19:22:08 -08:00
mailers/fundraising Move most fundraising files into a Fundraising module 2024-02-18 20:12:14 -08:00
models Fix MissingAttributeError in ClosetHanger#merge_quantities 2024-02-28 13:30:55 -08:00
services Save manifest load info when preloading them, too 2024-02-25 16:02:36 -08:00
views Add warning for "Baby Body Paint" bugs 2024-02-27 18:16:23 -08:00