1
0
Fork 0
forked from OpenNeo/impress
impress/app
Emi Matchu 1972ecf043 Use async instead of defer for analytics script
We had this issue on Impress 2020 and I fixed it over there too. I guess
it went less noticed here on Classic, because it's a more
progressively-enhanced site in general (and this failure case is an
interesting argument for that architecture! lol).

On Impress 2020, I wasn't sure if the "waits for the document to load"
behavior of the `defer` attribute was necessary to the script, so I
chose to keep `defer` but move it _after_ the other scripts.

This time, I dug in a bit more, and found a Plausible author saying
that the choice was kinda arbitrary; and another person who had the
same issue as me, who said they switched to `async` and it worked well.
So, that's what we're doing now, too!

https://github.com/plausible/analytics/discussions/1907#discussioncomment-2754499
2024-08-31 12:15:27 -07:00
..
assets Add better support for hashed pet names 2024-08-31 12:07:52 -07:00
controllers Oops, fix crashing bug when Item Getting Guide has *no* Dyeworks 2024-06-17 13:03:12 -07:00
helpers Remove SSW link, does not work on neopets anymore 2024-08-30 01:46:59 -04:00
javascript Release the Shopping List button to everyone 2024-07-09 13:39:20 -07:00
mailers/fundraising Move most fundraising files into a Fundraising module 2024-02-18 20:12:14 -08:00
models Merge remote-tracking branch 'origin/main' 2024-07-01 14:56:08 -07:00
services Load *all* NC Mall pages in nc_mall:sync 2024-05-10 17:39:40 -07:00
views Use async instead of defer for analytics script 2024-08-31 12:15:27 -07:00