dice/impress
1
0
Fork 0
forked from OpenNeo/impress
Code Pull requests Activity

Oops, fix missing field in item search results Apollo cache!

Browse source 
Oh right, `imageUrl` is the name of the field relative to what the app
expects, but under the hood `useOutfitAppearance` actually makes that
an alias for `imageUrlV2(idealSize: SIZE_600)`.

So we need to cache it as the same field with the same params, rather
than as just plain `imageUrl`!

This fixes the bug where wearing an item from search would require a
network round-trip and visually remove all items in the meantime.

(Also, none of this issue was visible to most users, because item
search is still feature-flagged onto the old GQL one for most people!)
This commit is contained in:
Emi Matchu 2024-02-27 12:43:28 -08:00
parent 66c1e14dd0
commit f3e10dea7f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/javascript/wardrobe-2020/loaders/items.js
View file

@ -136,7 +136,7 @@ function writeItemToApolloCache(item, { speciesId, colorId, altStyleId }) {
knownGlitches knownGlitches
svgUrl svgUrl
canvasMovieLibraryUrl canvasMovieLibraryUrl
imageUrl imageUrl: imageUrlV2(idealSize: SIZE_600)
swfUrl swfUrl
zone { zone {
id id