Link to the NC Mall homepage from the Shopping List

We were previously planning a more interesting "Add to Cart"
integration with TNT, but it hasn't panned out! For now, we'll just
link to the NC Mall homepage.

app/helpers/application_helper.rb

@@ -21,14 +21,26 @@ module ApplicationHelper
     end
   end
 
-  def button_link_to(content, url, icon: nil, **options)
+  def button_link_to(content_or_url, url = nil, icon: nil, **options)
+    if url.present?
+      content = content_or_url
+      url = url
+    else
+      content = nil
+      url = content_or_url
+    end
+
     klass = options.fetch(:class, "") + " button"
     link_to url, class: klass, **options do
       concat icon
       concat " "
+      if block_given?
+        yield
+      else
         concat content
       end
     end
+  end
 
   def advertise_campaign_progress(campaign, &block)
     if campaign && campaign.advertised?

app/views/items/sources.html.haml

@@ -27,16 +27,16 @@
 
 					%td.actions-cell
 						- if @items_needed[:nc_mall].present?
-							%button{
+							= button_link_to "https://ncmall.neopets.com/",
-								onclick: "alert('Todo!')",
+							  target: "_blank",
-								data: {"action-kind": "bulk-nc-mall"},
+							  data: {"action-kind": "bulk-nc-mall"} do
-							}
 								= cart_icon alt: ""
 								Buy all in NC Mall
 		%tbody
 			- @items[:nc_mall].each do |item|
 				= render "item_list_row", item: do
-					%button{onclick: "alert('Todo!')"}
+					= button_link_to "https://ncmall.neopets.com/",
+					  target: "_blank" do
 						= cart_icon alt: ""
 						Buy (#{item.current_nc_price} NC)
 
@@ -74,10 +74,9 @@
 						(~#{dyeworks_estimated_potions_cost_for @items_needed[:dyeworks]} NC)
 				%td.actions-cell
 					- if @items_needed[:dyeworks].present?
-						%button{
+						= button_link_to "https://ncmall.neopets.com/",
-							onclick: "alert('Todo!')",
+						  target: "_blank",
-							data: {"action-kind": "bulk-nc-mall"},
+						  data: {"action-kind": "bulk-nc-mall"} do
-						}
 							= cart_icon alt: ""
 							Buy all in NC Mall
 		%tbody
@@ -112,7 +111,8 @@
 								}
 									(Limited-time)
 
-					%button{onclick: "alert('Todo!')"}
+					= button_link_to "https://ncmall.neopets.com/",
+					  target: "_blank" do
 						= cart_icon alt: ""
 						Buy base (#{item.dyeworks_base_item.current_nc_price} NC)