add basic caching - TODO: avoid these computations in the controller

app/controllers/outfits_controller.rb

@@ -47,7 +47,7 @@ class OutfitsController < ApplicationController
     end
     
     unless localized_fragment_exist?('outfits#new newest_items')
-      newest_items = Item.newest.select([:id, :thumbnail_url, :rarity_index]).
+      newest_items = Item.newest.select([:id, :updated_at, :thumbnail_url, :rarity_index]).
         includes(:translations).limit(18)
       @newest_modeled_items, @newest_unmodeled_items =
         newest_items.partition(&:predicted_fully_modeled?)

app/helpers/outfits_helper.rb

@@ -55,12 +55,14 @@ module OutfitsHelper
   end
 
   def render_predicted_missing_species_by_color(species_by_color)
+    # Transform the Color => Array<Species> map into an Array<Pair<Color's
+    # human name (empty if standard), Array<Species>>>.
     # TODO: i18n
     standard = species_by_color.delete(:standard)
     sorted_pairs = species_by_color.to_a.map { |k, v| [k.human_name, v] }.
                                          sort_by { |k, v| k }
     sorted_pairs.unshift(['', standard]) if standard
-    species_by_color[:standard] = standard # undo mutation
+    species_by_color[:standard] = standard # undo parameter mutation
 
     first = true
     contents = sorted_pairs.map { |color_human_name, species|

app/views/outfits/new.html.haml

@@ -74,28 +74,28 @@
 
 #whats-new
   -# TODO: remove newest_items.header i18n key?
-  - localized_cache 'outfits#new newest_items' do
+  -# TODO: i18n all the things
-    - if @newest_unmodeled_items.present?
+  -# TODO: cache this entire block? or just request newest items every time?
-      %h3 We need your help! Can you model these items?
+  - if @newest_unmodeled_items.present?
-      %ul#newest-unmodeled-items
+    %h3 We need your help! Can you model these items?
-        - @newest_unmodeled_items.each do |item|
+    %ul#newest-unmodeled-items
+      - @newest_unmodeled_items.each do |item|
+        - localized_cache "items/#{item.id} modeling_progress updated_at=#{item.updated_at.to_i}" do
           %li
             = link_to image_tag(item.thumbnail_url), item, :class => 'image-link'
             = link_to item, :class => 'header' do
-              -# TODO: i18n
               %h2= item.name
-              -#: we need #{lolremove} more models
               %span.meter{style: "width: #{@newest_unmodeled_items_predicted_modeled_ratio[item]*100}%"}
             .missing-bodies
               = render_predicted_missing_species_by_color(@newest_unmodeled_items_predicted_missing_species_by_color[item])
-    - if @newest_modeled_items.present?
+  - if @newest_modeled_items.present?
-      %h3 These items have already been modeled—thanks for your help!
+    %h3 These items have already been modeled—thanks for your help!
-      %ul#newest-modeled-items
+    %ul#newest-modeled-items
-        - @newest_modeled_items.each do |item|
+      - @newest_modeled_items.each do |item|
-          %li.object
+        %li.object
-            = link_to item, title: item.name, alt: item.name do
+          = link_to item, title: item.name, alt: item.name do
-              = image_tag item.thumbnail_url
+            = image_tag item.thumbnail_url
-              = nc_icon_for(item)
+            = nc_icon_for(item)
 
 
 - localized_cache :action_suffix => 'templates' do