From 77d88e50a65808b735ff5372d2c8c00b0c9fa780 Mon Sep 17 00:00:00 2001
From: Emi Matchu <emi@matchu.dev>
Date: Sun, 21 Jan 2024 05:41:55 -0800
Subject: [PATCH] Oh right, make the item kind badges translatable!

Also make it an abbr, which means we need to override the default
text-decoration on it
---
 app/assets/stylesheets/partials/_item_header.sass |  1 +
 app/views/items/_item_header.haml                 | 12 ++++++------
 config/locales/en-MEEP.yml                        |  1 -
 config/locales/en.yml                             | 11 ++++++++++-
 config/locales/es.yml                             |  1 -
 config/locales/pt.yml                             |  1 -
 6 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/app/assets/stylesheets/partials/_item_header.sass b/app/assets/stylesheets/partials/_item_header.sass
index 5d5209e9..5043a442 100644
--- a/app/assets/stylesheets/partials/_item_header.sass
+++ b/app/assets/stylesheets/partials/_item_header.sass
@@ -40,6 +40,7 @@
         padding: .25em .5em
         border-radius: .25em
         cursor: help
+        text-decoration: none
 
         font-weight: bold
         line-height: 1
diff --git a/app/views/items/_item_header.haml b/app/views/items/_item_header.haml
index 3494ed75..03241449 100644
--- a/app/views/items/_item_header.haml
+++ b/app/views/items/_item_header.haml
@@ -8,14 +8,14 @@
     %h2.item-name= item.name
     %nav.item-links
       - if item.nc?
-        .item-kind{'data-type' => 'nc', title: 'Purchaseable with Neocash'}
-          NC
+        %abbr.item-kind{'data-type' => 'nc', title: t('items.show.item_kinds.nc.description')}
+          = t('items.show.item_kinds.nc.label')
       - elsif item.pb?
-        .item-kind{'data-type' => 'pb', title: 'Only obtainable via paintbrush'}
-          PB
+        %abbr.item-kind{'data-type' => 'pb', title: t('items.show.item_kinds.pb.description')}
+          = t('items.show.item_kinds.pb.label')
       - else
-        .item-kind{'data-type' => 'np', title: 'Purchaseable with Neopoints'}
-          NP
+        %abbr.item-kind{'data-type' => 'np', title: t('items.show.item_kinds.np.description')}
+          = t('items.show.item_kinds.np.label')
 
       = link_to t('items.show.resources.jn_items'), jn_items_url_for(item)
       - if item.nc_trade_value
diff --git a/config/locales/en-MEEP.yml b/config/locales/en-MEEP.yml
index ff32a82c..938e4144 100644
--- a/config/locales/en-MEEP.yml
+++ b/config/locales/en-MEEP.yml
@@ -270,7 +270,6 @@ en-MEEP:
         description: You want this meepit
 
     show:
-      rarity: Meepity
       resources:
         jn_items: JN Meepits
         shop_wizard: Meep Wizard
diff --git a/config/locales/en.yml b/config/locales/en.yml
index da472e93..7d6af415 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -298,7 +298,16 @@ en:
         description: You want this item
 
     show:
-      rarity: Rarity
+      item_kinds:
+        nc:
+          label: NC
+          description: Purchaseable with Neocash
+        np:
+          label: NP
+          description: Purchaseable with Neopoints
+        pb:
+          label: PB
+          description: Only obtainable via paintbrush
       resources:
         jn_items: JN Items
         owls: "Owls: %{value}"
diff --git a/config/locales/es.yml b/config/locales/es.yml
index 093b99b5..b5df35dc 100644
--- a/config/locales/es.yml
+++ b/config/locales/es.yml
@@ -209,7 +209,6 @@ es:
         abbr: Buscado
         description: Quieres este objeto
     show:
-      rarity: Rareza
       resources:
         jn_items: Objetos de JN
         shop_wizard: Asistente de Tiendas
diff --git a/config/locales/pt.yml b/config/locales/pt.yml
index d7093dca..27baaf8d 100644
--- a/config/locales/pt.yml
+++ b/config/locales/pt.yml
@@ -209,7 +209,6 @@ pt:
         abbr: Procura
         description: Você procura esse item
     show:
-      rarity: Raridade
       resources:
         jn_items: JN Itens
         shop_wizard: Mágico Pecincheiro