dice/impress
1
0
Fork 0
forked from OpenNeo/impress
Code Pull requests Activity

Actually, not-glitched is more important in item previews than pose

Browse source 
I took this ordering from a specific place on Impress 2020, but I think
that was in a context where the pose mattered more? Here though, I'm
realizing that I'd rather show any known-unglitched pose than the happy
masc or whatever we semi-randomly chose.
This commit is contained in:
Emi Matchu 2024-09-08 12:08:15 -07:00
parent 0b4d6dc7e6
commit 5f2c454423
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/models/pet_type.rb
View file

@ -122,10 +122,15 @@ class PetType < ApplicationRecord
pet_states.sort_by { |pet_state| pet_states.sort_by { |pet_state|
gender = pet_state.female? ? :fem : :masc gender = pet_state.female? ? :fem : :masc
[ [
# We prefer labeled pet states first, because states no one has seen or
# validated are such a wildcard! Then we prefer unglitched, then we
# prefer maximally happy. (Correct sad is better than glitched happy!)
# Then we pick our arbitrary-ish gender, then we pick the latest if all
# else failed and it's an unlabeled free-for-all.
pet_state.mood_id.present? ? -1 : 1, # Prefer mood is labeled pet_state.mood_id.present? ? -1 : 1, # Prefer mood is labeled
!pet_state.glitched? ? -1 : 1, # Prefer is not glitched
pet_state.mood_id, # Prefer mood is happy, then sad, then sick pet_state.mood_id, # Prefer mood is happy, then sad, then sick
gender == preferred_gender ? -1 : 1, # Prefer our "random" gender gender == preferred_gender ? -1 : 1, # Prefer our "random" gender
!pet_state.glitched? ? -1 : 1, # Prefer is not glitched
-pet_state.id, # Prefer newer pet states -pet_state.id, # Prefer newer pet states
] ]
}.first }.first