dice/impress
1
0
Fork 0
forked from OpenNeo/impress
Code Pull requests Activity

Use images without awaiting conversion anymore

Browse source 
We set up `impress-asset-images.openneo.net` to redirect to the right asset, without needing to depend on AWS anymore for HTML5-converted items!

Our quick fix for this: always serve `has_image: true` to the frontend, so it always tries to use the image, regardless of whether we've marked it as converted in the database. (We've turned off the converters too!)
This commit is contained in:
Emi Matchu 2022-10-15 16:26:12 -07:00 committed by GitHub
parent 515b089b3b
commit 4f357c2f9c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/models/swf_asset.rb
View file

@ -199,7 +199,10 @@ class SwfAsset < ActiveRecord::Base
:zone_id => zone_id, :zone_id => zone_id,
:zones_restrict => zones_restrict, :zones_restrict => zones_restrict,
:is_body_specific => body_specific?, :is_body_specific => body_specific?,
:has_image => has_image?, # Now that we don't proactively convert images anymore, let's just always
# say `has_image: true` when sending data to the frontend, so it'll use the
# new URLs anyway!
:has_image => true,
:images => images :images => images
} }
if options[:for] == 'wardrobe' if options[:for] == 'wardrobe'
@ -318,4 +321,3 @@ class SwfAsset < ActiveRecord::Base
File.join(relevant_pieces) File.join(relevant_pieces)
end end
end end