dice/impress
1
0
Fork 0
forked from OpenNeo/impress
Code Pull requests Activity

Improve species/color name migration performance & correctness

Browse source 
Oh right, this should only run in the up direction! And also we can get
a lot faster by preloading the translations.
This commit is contained in:
Emi Matchu 2024-01-23 05:30:42 -08:00
parent ce64f12cc3
commit 413d2eed91
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
db/migrate/20240123125509_add_name_to_species_and_color.rb
View file

@ -3,14 +3,18 @@ class AddNameToSpeciesAndColor < ActiveRecord::Migration[7.1]
add_column :species, :name, :string, null: false add_column :species, :name, :string, null: false
add_column :colors, :name, :string, null: false add_column :colors, :name, :string, null: false
Species.find_each do |species| reversible do |direction|
direction.up do
Species.includes(:translations).find_each do |species|
species.name = species.translation_for(:en).name species.name = species.translation_for(:en).name
species.save! species.save!
end end
Color.find_each do |color| Color.includes(:translations).find_each do |color|
color.name = color.translation_for(:en).name color.name = color.translation_for(:en).name
color.save! color.save!
end end
end end
end
end
end end