dice/impress
1
0
Fork 0
forked from OpenNeo/impress
Code Pull requests Activity

Refactor Item Getting Guide table rows to use a shared template

Browse source 
I'm gonna add more stuff like linking to the item page and stuff, and
that's starting to get complex enough to not want to repeat myself!
This commit is contained in:
Emi Matchu 2024-05-21 18:48:29 -07:00
parent 8440a28898
commit 39c05b8dac
2 changed files with 13 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/views/items/_item_list_row.html.haml Normal file
View file

@ -0,0 +1,4 @@
%tr
%td.thumbnail-cell= item_thumbnail_for(item)
%td= item.name
%td.actions-cell= yield

24
app/views/items/sources.html.haml
View file

@ -24,13 +24,10 @@
Buy all in NC Mall
%tbody
- @nc_mall_items.each do |item|
%tr
%td.thumbnail-cell= item_thumbnail_for(item)
%td= item.name
%td.actions-cell
%button{onclick: "alert('Todo!')"}
= cart_icon alt: ""
Buy (#{item.current_nc_price} NC)
= render "item_list_row", item: do
%button{onclick: "alert('Todo!')"}
= cart_icon alt: ""
Buy (#{item.current_nc_price} NC)
- if @np_items.present?
%h2 Neopoint items
@ -50,14 +47,11 @@
Total: #{pluralize @np_items.size, "item"}
%tbody
- @np_items.each do |item|
%tr
%td.thumbnail-cell= item_thumbnail_for(item)
%td= item.name
%td.actions-cell
= button_link_to "Shops", shop_wizard_url_for(item),
target: "_blank", icon: search_icon
= button_link_to "Trades", trading_post_url_for(item),
target: "_blank", icon: search_icon
= render "item_list_row", item: do
= button_link_to "Shops", shop_wizard_url_for(item),
target: "_blank", icon: search_icon
= button_link_to "Trades", trading_post_url_for(item),
target: "_blank", icon: search_icon
- if @pb_items.present?
%h2 Paintbrush items