dice/impress
1
0
Fork 0
forked from OpenNeo/impress
Code Pull requests Activity

Add explanations for why Item#pb_{species,color} would return nil

Browse source
This commit is contained in:
Emi Matchu 2024-06-05 19:46:12 -07:00
parent a3bd841bb8
commit 31c281390d
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/models/item.rb
View file

@ -208,7 +208,11 @@ class Item < ApplicationRecord
end
# If this is a PB item, return the corresponding Color, inferred from the
# item name. If it's not a PB item, or we fail to infer, return nil.
# item name. If it's not a PB item, or we fail to infer a specific color,
# return nil. (This is expected to be nil for some PB items, like the "Aisha
# Collar", which belong to many colors. It can also be nil for PB items for
# new colors we haven't manually added to the database yet, or if a PB item
# is named strangely in the future.)
def pb_color
return nil unless pb?
@ -226,7 +230,10 @@ class Item < ApplicationRecord
end
# If this is a PB item, return the corresponding Species, inferred from the
# item name. If it's not a PB item, or we fail to infer, return nil.
# item name. If it's not a PB item, or we fail to infer a specific species,
# return nil. (This is not expected to be nil in general, but could be for PB
# items for new species we haven't manually added to the database yet, or if
# a PB item is named strangely in the future.)
def pb_species
return nil unless pb?
normalized_name = name.downcase