dice/impress
1
0
Fork 0
forked from OpenNeo/impress
Code Pull requests Activity

Fix createjs loading

Browse source 
Tricky little thing! Directly importing I think doesn't work because it thinks `this` refers to something other than `window`? This fixes it tho!
This commit is contained in:
Emi Matchu 2023-08-10 17:19:50 -07:00
parent 3c1fcca986
commit 2884914cbe
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/javascript/wardrobe-2020/components/OutfitMovieLayer.js
View file

@ -5,11 +5,16 @@ import { Box, Grid, useToast } from "@chakra-ui/react";
import { loadImage, logAndCapture, safeImageUrl } from "../util"; import { loadImage, logAndCapture, safeImageUrl } from "../util";
import usePreferArchive from "./usePreferArchive"; import usePreferArchive from "./usePreferArchive";
// Importing EaselJS and TweenJS puts them directly into the `window` object! // Import EaselJS and TweenJS as strings to run in a global context!
// The bundled scripts are built to attach themselves to `window.createjs`, and // The bundled scripts are built to attach themselves to `window.createjs`, and
// `window.createjs` is where the Neopets movie libraries expects to find them! // `window.createjs` is where the Neopets movie libraries expects to find them!
import "easeljs/lib/easeljs"; //
import "tweenjs/lib/tweenjs"; // TODO: Is there a nicer way to do this within esbuild? Would be nice to have
// builds of these libraries that just play better in the first place...
import easelSource from "easeljs/lib/easeljs.min.js";
import tweenSource from "tweenjs/lib/tweenjs.min.js";
new Function(easelSource).call(window);
new Function(tweenSource).call(window);
function OutfitMovieLayer({ function OutfitMovieLayer({
libraryUrl, libraryUrl,

2
package.json
View file

@ -25,6 +25,6 @@
"tweenjs": "^1.0.2" "tweenjs": "^1.0.2"
}, },
"scripts": { "scripts": {
"build": "esbuild app/javascript/*.* --bundle --sourcemap --outdir=app/assets/builds --public-path=/assets --loader:.js=jsx --loader:.png=file --loader:.svg=file" "build": "esbuild app/javascript/*.* --bundle --sourcemap --outdir=app/assets/builds --public-path=/assets --loader:.js=jsx --loader:.png=file --loader:.svg=file --loader:.min.js=text"
} }
} }