impress/app/views/items/_item_link.html.haml

= link_to item_path(item) do
  = image_tag item.thumbnail_url, :alt => item.description, :title => item.description
  %span.name= item.name
  = nc_icon_for(item)
Move item_link partial caching to a helper rather than the template itself This is a surprisingly huge performance gain. On my testing (with cache_classes set to true to also cache templates), this sped up closet_hangers#index rendering by a factor of 2 when there were a significant number of items. Cool beans. I think we can even hold off on the individual hanger caching now: we've made the closet hanger partial tons faster by moving forms out of them and doing this cache check earlier. I'm expecting significant performance gains both here and on items#index (though less so there). I'll deploy and see how much it helps in production; if not enough, we can look at the layered caching of hangers, lists, groups, full pages, etc. So glad we don't have to move to a pagination model! 2013-06-22 16:31:46 -07:00			`= link_to item_path(item) do`
Remove no-op item.thumbnail.secure_url There was a time when I used an old proxy server to try to fix mixed content issues, and I eventually removed it but never took the tendrils out from the code. We probably _should_ figure out how to secure these URLs! But until then, we may as well simplify the code. 2023-11-11 08:24:08 -08:00			`= image_tag item.thumbnail_url, :alt => item.description, :title => item.description`
Move item_link partial caching to a helper rather than the template itself This is a surprisingly huge performance gain. On my testing (with cache_classes set to true to also cache templates), this sped up closet_hangers#index rendering by a factor of 2 when there were a significant number of items. Cool beans. I think we can even hold off on the individual hanger caching now: we've made the closet hanger partial tons faster by moving forms out of them and doing this cache check earlier. I'm expecting significant performance gains both here and on items#index (though less so there). I'll deploy and see how much it helps in production; if not enough, we can look at the layered caching of hangers, lists, groups, full pages, etc. So glad we don't have to move to a pagination model! 2013-06-22 16:31:46 -07:00			`%span.name= item.name`
			`= nc_icon_for(item)`