impress/app/views/items/_item_link.html.haml

-# NOTE: Changing this requires bumping the cache at `_closet_list.html.haml`!
= link_to item_path(item) do
  = image_tag item.thumbnail_url, alt: "Thumbnail for #{item.name}",
    title: item.description, loading: "lazy"
  %span.name= item.name
  = nc_icon_for(item)
High-level caching for closet lists Okay, so I still don't know why rendering is just so slow (though migrating away from item translations did help!), but I can at least cache entire closet lists as a basic measure. That way, the first user to see the latest version of a closet list will still need just as much time to load it… but only the ones that have changed since last time (rather than always the full page), and then subsequent users get to reuse it too! Should help a lot for high-traffic lists, which incidentally are likely to be the big ones belonging to highly active traders! One big change we needed to make was to extract the `user-owns` and `user-wants` classes (which we use for trade matches for the user viewing the list right now) out of the cached HTML, and apply them after with Javascript instead. I always dislike moving stuff to JS, but the wins here seem. truly very very good, all things considered! 2024-02-20 18:42:42 -08:00			-# NOTE: Changing this requires bumping the cache at `_closet_list.html.haml`!
Move item_link partial caching to a helper rather than the template itself This is a surprisingly huge performance gain. On my testing (with cache_classes set to true to also cache templates), this sped up closet_hangers#index rendering by a factor of 2 when there were a significant number of items. Cool beans. I think we can even hold off on the individual hanger caching now: we've made the closet hanger partial tons faster by moving forms out of them and doing this cache check earlier. I'm expecting significant performance gains both here and on items#index (though less so there). I'll deploy and see how much it helps in production; if not enough, we can look at the layered caching of hangers, lists, groups, full pages, etc. So glad we don't have to move to a pagination model! 2013-06-22 16:31:46 -07:00			`= link_to item_path(item) do`
High-level caching for closet lists Okay, so I still don't know why rendering is just so slow (though migrating away from item translations did help!), but I can at least cache entire closet lists as a basic measure. That way, the first user to see the latest version of a closet list will still need just as much time to load it… but only the ones that have changed since last time (rather than always the full page), and then subsequent users get to reuse it too! Should help a lot for high-traffic lists, which incidentally are likely to be the big ones belonging to highly active traders! One big change we needed to make was to extract the `user-owns` and `user-wants` classes (which we use for trade matches for the user viewing the list right now) out of the cached HTML, and apply them after with Javascript instead. I always dislike moving stuff to JS, but the wins here seem. truly very very good, all things considered! 2024-02-20 18:42:42 -08:00			`= image_tag item.thumbnail_url, alt: "Thumbnail for #{item.name}",`
			`title: item.description, loading: "lazy"`
Move item_link partial caching to a helper rather than the template itself This is a surprisingly huge performance gain. On my testing (with cache_classes set to true to also cache templates), this sped up closet_hangers#index rendering by a factor of 2 when there were a significant number of items. Cool beans. I think we can even hold off on the individual hanger caching now: we've made the closet hanger partial tons faster by moving forms out of them and doing this cache check earlier. I'm expecting significant performance gains both here and on items#index (though less so there). I'll deploy and see how much it helps in production; if not enough, we can look at the layered caching of hangers, lists, groups, full pages, etc. So glad we don't have to move to a pagination model! 2013-06-22 16:31:46 -07:00			`%span.name= item.name`
			`= nc_icon_for(item)`