dice/impress
1
0
Fork 0
forked from OpenNeo/impress
Code Pull requests Activity
impress/app/views/items/_item_list_row.html.haml

16 lines
447 B
Text
Raw Normal View History

Oops, fix bug with empty subtitles in Item Getting Guide Oh weird, even with `flush: true`, `content_for` will ignore an empty block and *not* flush out the previous content. This could cause rows whose subtitles *should* have been empty (e.g. no NC trade value) to display the previous row's value instead. Let's make this whole situation a bit more robust by having the *template* clear out the subtitle right before calling the block. That way, a previous row's value *can't* get in, no matter what.
2024-06-09 15:40:58 -07:00
-# Run the block first, so we can get the subtitle content if provided! Clear
-# out any old values beforehand, too.
- content_for :subtitle, "", flush: true
Move Item Getting Guide subtitle UI out of helpers, into templates I thought to myself, "I wonder if it's possible to use a sneaky hacky `content_for` trick to be able to run this code in the template." And indeed it is! It's tricky cuz like, I want to render this template, and I want to provide _multiple_ slots of content to it. So, in this variant, we keep the block as being primarily for the actions, but also optionally accept `content_for :subtitle` inside that block, too. Executing that correctly is a bit tricky! The subtitle comes *before* the actions. So, we `yield` the actions block immediately, save it to a variable, and *then* get the subtitle block.
2024-06-09 15:03:35 -07:00
- content = yield
- subtitle = yield :subtitle
Oops, fix recent bug in Item Getting Guide for most item types Oh oops, I added an optional `subtitle` argument for the item table list row template, but didn't realize that it would crash in cases when not provided! Now, we add an initializer to set it to `nil` if undefined.
2024-05-28 17:05:28 -07:00
Refactor Item Getting Guide table rows to use a shared template I'm gonna add more stuff like linking to the item page and stuff, and that's starting to get complex enough to not want to repeat myself!
2024-05-21 18:48:29 -07:00
%tr
Improve row focus and keyboard nav in Item Getting Guide Clearer focus states, row changes bg color on hover/focus to help you track where you are, remove the redundant image thumbnail link from the tab order (it's the same as the item name link!)
2024-05-22 14:57:28 -07:00
%td.thumbnail-cell
= link_to item_thumbnail_for(item), item, target: "_blank",
tabindex: "-1"
Add OWLS values to non-NC-Mall NC items in Item Getting Guide Note that there's a known performance issue here: we should try to fetch all the OWLS values at once, instead of doing them in sequence while rendering the page!
2024-05-27 15:50:41 -07:00
%td.name-cell
= link_to item.name, item, target: "_blank"
- if subtitle.present?
.subtitle= subtitle
Move Item Getting Guide subtitle UI out of helpers, into templates I thought to myself, "I wonder if it's possible to use a sneaky hacky `content_for` trick to be able to run this code in the template." And indeed it is! It's tricky cuz like, I want to render this template, and I want to provide _multiple_ slots of content to it. So, in this variant, we keep the block as being primarily for the actions, but also optionally accept `content_for :subtitle` inside that block, too. Executing that correctly is a bit tricky! The subtitle comes *before* the actions. So, we `yield` the actions block immediately, save it to a variable, and *then* get the subtitle block.
2024-06-09 15:03:35 -07:00
%td.actions-cell= content
Copy permalink