forked from OpenNeo/impress-2020
Matchu
f6ce8611b2
Two fixes in here, for when image downloads fail! 1) Actually catch the error, and show UI feedback 2) Throw it as an actual exception, so the console message will have a stack trace Additionally, debugging this was a bit trickier than normal, because I didn't fully understand that the image `onerror` argument is an error _event_, not an Error object. So, Sentry captured the uncaught promise rejection, but it didn't have trace information, because it wasn't an Error. Whereas now, if I forget to catch `loadImage` calls in the future, we'll get a real trace! both in the console for debugging, and in Sentry if it makes it to prod :) |
||
|---|---|---|
| .. | ||
| support | ||
| index.js | ||
| Item.js | ||
| ItemsAndSearchPanels.js | ||
| ItemsPanel.js | ||
| OutfitControls.js | ||
| PosePicker.js | ||
| SearchPanel.js | ||
| SearchToolbar.js | ||
| useOutfitState.js | ||
| WardrobeDevHacks.js | ||
| WardrobeOutfitPreview.js | ||
| WardrobePageLayout.js | ||