forked from OpenNeo/impress-2020
Matchu
753305dd11
Previously, when you navigated directly to an outfit by typing the URL into the browser or following an external link, the name would stay as "Untitled outfit", even after the outfit loaded.
This was because, when you render an `Editable` Chakra component with `value={undefined}`, it permanently enters "uncontrolled" mode, and providing a value later doesn't change that.
But tbh passing `undefined` down from outfit state wasn't my intention! But yeah, turns out the `?.` operator returns `undefined` rather than `null`, which I guess makes sense!
So, I've fixed this on both ends. I'm now passing more `null`s down via outfit state, because I think that's a more expected value in general.
But also, for the `Editable`, I'm making a point of passing in an empty string as `value`, so that this component will be resilient to upstream changes in the future. (It's pretty brittle to _depend_ on the difference between `null` and `undefined`, as we saw here 😅)
|
||
|---|---|---|
| .. | ||
| support | ||
| index.js | ||
| Item.js | ||
| ItemsAndSearchPanels.js | ||
| ItemsPanel.js | ||
| OutfitControls.js | ||
| PosePicker.js | ||
| SearchPanel.js | ||
| SearchToolbar.js | ||
| useOutfitState.js | ||
| WardrobeDevHacks.js | ||
| WardrobeOutfitPreview.js | ||
| WardrobePageLayout.js | ||