From 1e4063f0d9cd95f585d0c2881afd42388227aafb Mon Sep 17 00:00:00 2001 From: Matchu Date: Mon, 12 Apr 2021 19:36:08 -0700 Subject: [PATCH] Add glitch DISPLAYS_INCORRECTLY_BUT_CAUSE_UNKNOWN I'm applying this to the "MiniMME11-S1: Approaching Eventide Skirt" on the Acara, which seems to load all 1000 images from the manifest, but then show no animation and no errors. Not sure what's up, and not inclined to deep-debug until we have a check on whether it works on-site! --- .../WardrobePage/OutfitKnownGlitchesBadge.js | 17 +++++++++++++++++ .../support/ItemLayerSupportModal.js | 6 ++++++ src/server/types/AppearanceLayer.js | 5 +++++ 3 files changed, 28 insertions(+) diff --git a/src/app/WardrobePage/OutfitKnownGlitchesBadge.js b/src/app/WardrobePage/OutfitKnownGlitchesBadge.js index f7db9ea..5d99fa6 100644 --- a/src/app/WardrobePage/OutfitKnownGlitchesBadge.js +++ b/src/app/WardrobePage/OutfitKnownGlitchesBadge.js @@ -89,6 +89,23 @@ function OutfitKnownGlitchesBadge({ appearance }) { } } + // Look for items with the DISPLAYS_INCORRECTLY_BUT_CAUSE_UNKNOWN glitch. + for (const item of items) { + const itemHasGlitch = item.appearance.layers.some((l) => + (l.knownGlitches || []).includes("DISPLAYS_INCORRECTLY_BUT_CAUSE_UNKNOWN") + ); + if (itemHasGlitch) { + glitchMessages.push( + + There's a glitch in the art for {item.name} that causes it to + display incorrectly—but we're not sure if it's on our end, or TNT's. + If you own this item, please email me at matchu@openneo.net to let us + know how it looks on-site! + + ); + } + } + // Look for items with the OFFICIAL_BODY_ID_IS_INCORRECT glitch. for (const item of items) { const itemHasOfficialBodyIdIsIncorrect = item.appearance.layers.some((l) => diff --git a/src/app/WardrobePage/support/ItemLayerSupportModal.js b/src/app/WardrobePage/support/ItemLayerSupportModal.js index a57e18a..18ea119 100644 --- a/src/app/WardrobePage/support/ItemLayerSupportModal.js +++ b/src/app/WardrobePage/support/ItemLayerSupportModal.js @@ -442,6 +442,12 @@ function ItemLayerSupportKnownGlitchesFields({ (Will use the PNG instead) + + Displays incorrectly, but cause unknown{" "} + + (Will display a vague message) + + Fits all pets on-site, but should not{" "} diff --git a/src/server/types/AppearanceLayer.js b/src/server/types/AppearanceLayer.js index 94de066..4e51cb2 100644 --- a/src/server/types/AppearanceLayer.js +++ b/src/server/types/AppearanceLayer.js @@ -100,6 +100,11 @@ const typeDefs = gql` # For affected layers, svgUrl will be null, regardless of the manifest. OFFICIAL_SVG_IS_INCORRECT + # This glitch means that we know the layer doesn't display correctly on + # DTI, but we're not sure why, or whether it works differently on-site. We + # show a vague apologetic message, asking users to send us info. + DISPLAYS_INCORRECTLY_BUT_CAUSE_UNKNOWN + # This glitch means that the official body ID for this asset is not correct # (usually 0), so it will fit some pets that it shouldn't. We reflect this # accurately on DTI, with a message to explain that it's not our error, and