impress/app/models
Matchu f8cf3fd701 Fix crash when searching for "is:nc"
Huh, Arel can *sometimes* handle just having an attribute stand in as
"X is true" in a condition, but sometimes gets upset about it. I guess
this changed in Rails since we recently wrote this?

Specifically, item search would crash on "is:nc" (but *not* "is:np"),
saying:

```
undefined method `fetch_attribute' for #<struct Arel::Attributes::Attribute relation=#<Arel::Table:0x0000000109a67110 @name="items", @klass=Item(…), @type_caster=#<ActiveRecord::TypeCaster::Map:0x0000000109a66e90 @klass=Item(…)>, @table_alias=nil>, name="is_manually_nc">
```

The traceback was a bit misleading (it happened at the part where we
merge all the scopes together), but that hinted to me that it working
with an attribute in a place where it expected a conditional. So I
converted the attribute in the `is_nc` scope to a conditional, and made
the matching change in `is_np`, and that fixed it! Ok phew!
2023-10-25 12:46:48 -07:00
..
item Oops, add species search filter back 2023-10-23 19:05:07 -07:00
application_record.rb Upgrade to Rails 5.2.8.1 2023-10-23 19:05:05 -07:00
auth_record.rb Add AuthUser model, connecting to openneo_id db 2023-10-23 19:05:07 -07:00
auth_user.rb Clarify the error behavior on AuthUser syncing 2023-10-23 19:05:08 -07:00
campaign.rb Upgrade to Rails 5.2.8.1 2023-10-23 19:05:05 -07:00
closet_hanger.rb Fix moving closet hanger to null-list 2023-10-23 19:05:06 -07:00
closet_list.rb Stop orphaning hangers when deleting lists 2023-10-24 15:35:21 -07:00
closet_visibility.rb Cache trade info on items#show, finally! I think it's the performance culprit. 2013-12-27 14:49:46 -05:00
color.rb Remove sanitize_sql_like monkey-patch 2023-10-23 19:05:07 -07:00
contribution.rb Upgrade to Rails 5.2.8.1 2023-10-23 19:05:05 -07:00
donation.rb Mark some more relationships as optional 2023-10-23 19:05:07 -07:00
donation_feature.rb Mark some more relationships as optional 2023-10-23 19:05:07 -07:00
fragment_expiration.rb only send cache deletions for usable locales 2013-12-08 23:44:25 -06:00
fragment_localization.rb i18n for outfits#new (and layouts#application), including caching 2013-01-24 18:23:18 -06:00
image.rb Delete Camo references & Addressable gem 2023-10-23 19:05:05 -07:00
item.rb Fix crash when searching for "is:nc" 2023-10-25 12:46:48 -07:00
item_outfit_relationship.rb Upgrade to Rails 5.2.8.1 2023-10-23 19:05:05 -07:00
neopets_connection.rb Upgrade to Rails 5.2.8.1 2023-10-23 19:05:05 -07:00
neopets_page.rb import from gallery 2015-07-28 15:05:40 -04:00
neopets_user.rb Fix old find_or_initialize_by methods 2023-10-23 19:05:09 -07:00
outfit.rb Remove slightly-broken edit outfit links from user outfits page 2023-10-24 18:05:51 -07:00
parent_swf_asset_relationship.rb Upgrade to Rails 5.2.8.1 2023-10-23 19:05:05 -07:00
pet.rb Skip item translations when modeling 2023-10-23 19:05:10 -07:00
pet_attribute.rb capitalize each word of a species/color name (for Swamp Gas) 2011-07-12 18:22:16 -04:00
pet_state.rb Fix more modeling bugs 2023-10-23 19:05:09 -07:00
pet_type.rb Upgrade to Rails 5.2.8.1 2023-10-23 19:05:05 -07:00
pretty_param.rb parameterize user params like items, plus a cleaner parameterization scheme 2011-07-26 18:49:52 -04:00
species.rb Remove sanitize_sql_like monkey-patch 2023-10-23 19:05:07 -07:00
static_resource.rb attempt to fix new species_support_ids format. sigh. 2013-01-23 00:25:09 -06:00
swf_asset.rb Skip item translations when modeling 2023-10-23 19:05:10 -07:00
user.rb Clarify the error behavior on AuthUser syncing 2023-10-23 19:05:08 -07:00
zone.rb Fix bug with Arel ordering 2023-10-23 19:05:05 -07:00