impress/app
Emi Matchu 95c1a4f391 Fix bugs in Settings page when changes to the model are incomplete
Ahh okay tricky lil thing: if you show the settings page with a partial
change to `AuthUser` that didn't get saved, it can throw off the state
of some stuff. For example, if you don't have a password yet, then
enter a new password but leave the confirmation box blank, then you'll
correctly see "Password confirmation can't be blank", but you'll *also*
then be prompted for your "Current password", even though you don't
have one yet, because `@auth_user.uses_password?` is true now.

In this change, we extend the Settings form to use two copies of the
`AuthUser`. One is the copy with changes on it, and the other is the
"persisted" copy, which we check for parts of the UI that care about
what's actually saved, vs form state.
2024-04-09 06:34:06 -07:00
..
assets Eject AuthUsersController from the default Devise controller 2024-04-08 04:02:54 -07:00
controllers Fix bugs in Settings page when changes to the model are incomplete 2024-04-09 06:34:06 -07:00
helpers Oh right, hide NeoPass on settings page unless you set the magic param! 2024-04-08 05:34:47 -07:00
javascript Oh wow, don't use the images.neopets.com asset proxy anymore either! 2024-04-06 03:38:23 -07:00
mailers/fundraising Move most fundraising files into a Fundraising module 2024-02-18 20:12:14 -08:00
models Oops, fix error when saving user settings with no password set 2024-04-09 06:20:13 -07:00
services Save manifest load info when preloading them, too 2024-02-25 16:02:36 -08:00
views Fix bugs in Settings page when changes to the model are incomplete 2024-04-09 06:34:06 -07:00