impress/app
Emi Matchu 7f4c34ff6a Oops, stop requiring a new password whenever AuthUser is changed
Ah right, I went and checked the Devise source code, and the default
implementation for `password_required?` is a bit trickier than I
expected:

```ruby
def password_required?
  !persisted? || !password.nil? || !password_confirmation.nil?
end
```

Looks like `super` does a good enough job here, though! (I'm actually
kinda surprised, I wasn't sure how Ruby's `super` rules worked, and
this isn't a subclass thing—or maybe it is, maybe the `devise` method
adds a mixin? Idk! But it does what I expect, so, great!)

So now, we require the password if 1) Devise doesn't see a UI reason
not to, *and* 2) the user isn't using OmniAuth (i.e. NeoPass).

This had caused a bug where it was impossible to use the Settings page
*without* changing your password! (The form says it's okay to leave it
blank, which stopped being true! But now it's fixed!)
2024-03-14 19:20:33 -07:00
..
assets Fix scoping on CSS for donate page 2024-03-13 22:13:16 -07:00
controllers Actually create user from NeoPass authentication! <3 <3 2024-03-14 19:11:06 -07:00
helpers Downgrade jQuery on homepage to be the same version as everywhere else 2024-03-13 21:38:45 -07:00
javascript Fix the Chakra CSS reset applying to too many things on item page 2024-03-13 20:57:30 -07:00
mailers/fundraising Move most fundraising files into a Fundraising module 2024-02-18 20:12:14 -08:00
models Oops, stop requiring a new password whenever AuthUser is changed 2024-03-14 19:20:33 -07:00
services Save manifest load info when preloading them, too 2024-02-25 16:02:36 -08:00
views NeoPass strategy interacts with dev NeoPass server, which is still WIP 2024-03-14 16:13:31 -07:00