impress/app/assets
Emi Matchu be0faaa36e Improve top nav support on mobile for responsive design pages
Before this change, pages that opt in with `use_responsive_design`
would often have the top nav be real cluttered for logged-in users. (I
think I happened to first test this responsive design without being
logged in on my dev box, oops!) Because the home link and `#userbar`
were absolutely positioned on the page, they would frequently overlap.

Here, I stop doing our old tricks to make the top nav load last on the
page. (This was to get "main content" loading faster, which I think is
a. not as relevant today with more commonly faster connections, and b.
was a bit naive to think that it'd be helpful to have to wait a long
time to _navigate_ if a page is unexpectedly large.)

These tricks used to leave some padding at the top of the `#container`,
which these elements would then visually fill via `position: absolute`
once they load.

Next, I update the CSS (for the responsive design pages only) to use
the new `#main-nav` container to lay them out in Flexbox: all in one
row if possible, or wrapped if needed.

Some designs hide stuff like this into a hamburger menu or such when
the screen gets small. I haven't done that here! No specific reason,
I'm just not sold that it's that much better, or worth the trouble.

I tested this on the following combinations:
1. Logged out, homepage
2. Logged in, homepage
3. Logged out, `/items`
4. Logged in, `/items`
5. Logged out, `/items/89487-Dyeworks-Purple-Haunted-Sky-Background`
6. Logged in, `/items/89487-Dyeworks-Purple-Haunted-Sky-Background`

Hope it's solid! 🤞
2024-10-05 17:52:38 -07:00
..
builds Bundle wardrobe-2020 into the app 2023-10-23 19:05:08 -07:00
config Move JS libraries to vendor/javascript 2024-09-13 21:16:46 -07:00
fonts Remove unused Delicious-Heavy.otf font 2024-09-13 20:39:22 -07:00
images Post perf upgrades announcement (and job-hunting ask 💖️) 2024-10-03 15:09:38 -07:00
javascripts Oops, fix item page's "Customize More" not animating after color change 2024-09-29 14:59:52 -07:00
stylesheets Improve top nav support on mobile for responsive design pages 2024-10-05 17:52:38 -07:00