Dress to Impress, a big fancy Neopets customization tool!
Emi Matchu
58d7c38523
Fun little bug: viewing the "Engulfed in Flames Effect" item was showing our "502 Bad Gateway" custom error page in the embed. This is because the Rails app was providing a `Content-Security-Policy` header value that was longer than nginx is configured by default to allow, so it was refusing the response, and showing the same 502 error as if the app hadn't responded at all. (We discovered this by opening `/var/log/nginx/error.log`, which explained this very clearly, ty~!) In this change, we no longer list every `images.neopets.com` asset, instead marking the entire domain as a valid image source for the SWF asset embed iframe. I don't _love_ this solution, I liked the property of specifying literally exactly the assets we allow! But I don't think there's any practical danger here, and it helps a *lot* for making this more reliable. (If we could have solved this reliably by increasing nginx's allowed response header size, I probably would've done that? But I researched a bit, and ultimately concluded that I don't trust other intermediary software like firewalls not to have the same issue. Let's not be pushing the limits of HTTP headers of all things!) |
||
|---|---|---|
| .devcontainer | ||
| .husky | ||
| app | ||
| bin | ||
| config | ||
| db | ||
| deploy | ||
| lib | ||
| public | ||
| test | ||
| vendor | ||
| .eslintrc.json | ||
| .gitignore | ||
| .prettierignore | ||
| .ruby-version | ||
| .solargraph.yml | ||
| .yarnrc.yml | ||
| config.ru | ||
| falcon.rb | ||
| Gemfile | ||
| Gemfile.lock | ||
| LICENSE.md | ||
| package.json | ||
| Procfile.dev | ||
| Rakefile | ||
| README.md | ||
| yarn.lock | ||
Dress to Impress
Oh! We've been revitalizing the Rails app! Fun!
There'll be more to say about it here soon :3