OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity
Dress to Impress, a big fancy Neopets customization tool!
2122 commits 6 branches 0 tags 301 MiB
Ruby 43.9%
JavaScript 37.2%
Haml 7.8%
Sass 6.2%
HTML 4.4%
Other 0.5%
Find a file
Emi Matchu 39bed6b157 Make Item's update_cached_fields callback more reliable 
In our tests, I discovered an unexpected behavior where calling
`item.swf_assets << swf_asset` wasn't updating computed fields
correctly.

This isn't something we actually do in-app, I think the modeling system
happened to trigger the callbacks in a way that still worked fine?

But I think this is a good idea for reliability, since caching is such
a notoriously difficult thing to get right anyway! And it makes our
tests simpler and clearer.

Specifically, `compatible_body_ids` references `swf_assets`, which, I'm
kinda surprised, *doesn't* include the newly-added asset yet when the
`ParentSwfAssetRelationship.after_save` hook runs while calling
`item.swf_assets << swf_asset`. Reloading it fixes this!
2024-11-19 14:26:06 -08:00
.devcontainer Save last trade activity time onto User 2024-01-19 00:00:46 -08:00
.husky Add RSpec to the commit hook 2024-10-24 15:22:39 -07:00
app Make Item's update_cached_fields callback more reliable 2024-11-19 14:26:06 -08:00
bin Move some Ansible config out of scripts and into ansible.cfg 2024-09-06 12:16:26 -07:00
config Say "NC Style" instead of "Alt Style" in contribution descriptions 2024-11-16 12:21:43 -08:00
db Remove some more incorrect limits on ID fields in the database 2024-11-15 20:39:38 -08:00
deploy Refactor Neopets import tasks all into a neopets:import namespace 2024-11-16 11:58:43 -08:00
lib Only prompt for Neologin cookie once when running rails neopets:import 2024-11-16 12:11:13 -08:00
public Rescue from ActiveRecord::ConnectionTimeoutError 2024-09-27 17:50:35 -07:00
spec Make Item's update_cached_fields callback more reliable 2024-11-19 14:26:06 -08:00
test Add assets to modeling tests, and also uhh some other fixes 2024-10-21 16:46:10 -07:00
vendor Add NCMall.load_styles method, not yet used 2024-11-14 18:45:08 -08:00
.eslintrc.json Set up eslint for wardrobe-2020 2023-11-02 18:11:07 -07:00
.gitignore Improve Solargraph LSP in our spec files 2024-11-19 11:28:36 -08:00
.rspec Move modeling tests to RSpec 2024-10-21 16:03:58 -07:00
.ruby-version Upgrade to Ruby 3.3.5, and improve the mechanisms for it a bit 2024-09-20 12:47:35 -07:00
.solargraph.yml Add Solargraph autocomplete while in development 2024-07-01 15:35:39 -07:00
.yarnrc.yml Upgrade to Yarn 4.0.2 2024-01-14 23:05:53 -08:00
config.ru Upgrade to Rails 6.1.7.4 2023-10-23 19:05:07 -07:00
falcon.rb Remove supervisor from the Falcon process? 2024-01-24 00:20:23 -08:00
Gemfile Improve Solargraph LSP in our spec files 2024-11-19 11:28:36 -08:00
Gemfile.lock Add NCMall.load_styles method, not yet used 2024-11-14 18:45:08 -08:00
LICENSE.md Update GitHub links to point to our self-hosted OpenNeo Code 2024-02-29 11:24:21 -08:00
package.json Upgrade to Yarn 4.5.0 2024-09-20 12:47:54 -07:00
Procfile.dev Use local-only HTTPS certs for the development neopass-server 2024-03-14 18:01:54 -07:00
Rakefile Uninstall resque 2023-10-23 19:05:04 -07:00
README.md Oops, needs to be a README.md file! 2023-10-25 16:31:41 -07:00
yarn.lock Upgrade typescript-eslint dependencies 2024-05-06 15:08:37 -07:00

README.md

Dress to Impress beach logo

Dress to Impress

Oh! We've been revitalizing the Rails app! Fun!

There'll be more to say about it here soon :3