OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Add better support for hashed pet names on bulk modeler #2

Closed
dice wants to merge 1 commit from dice:enhance-hashed-pets into main
pull from: dice:enhance-hashed-pets
merge into: OpenNeo:main
Conversation 1 Commits 1 Files changed 2 +8 -1
dice commented 2024-08-29 22:58:26 -07:00
Contributor
Copy link

I think this is sufficient...

I _think_ this is sufficient...
dice added 1 commit 2024-08-29 22:58:26 -07:00
matchu force-pushed enhance-hashed-pets from 2faa89dd4c to e80a49a086 2024-08-30 17:57:59 -07:00 Compare
matchu requested changes 2024-08-30 18:05:43 -07:00
matchu left a comment
Owner
Copy link

Idk Github-style flows for this, I'm marking this "Request changes" but I can probably attend to the changes myself later—I also don't know how that works in PR style though, like, can I add my own commits to this? Or is the style more like, I would branch off this PR into one of my own? Or something?

Idk Github-style flows for this, I'm marking this "Request changes" but I can probably attend to the changes myself later—I also don't know how that works in PR style though, like, _can_ I add my own commits to this? Or is the style more like, I would branch off this PR into one of my own? Or something?
app/views/pets/bulk.html.haml
@ -72,0 +71,4 @@
- if pet_name.starts_with?('@')
%img{:src => 'https://pets.neopets.com/cp/${pet_name[1..-1]}/1/1.png'}
- else
%img{:src => 'https://pets.neopets.com/cpn/${pet_name}/1/1.png'}
matchu commented 2024-08-30 18:04:42 -07:00
Owner
Copy link

Ohhh ok so, this section is a bit tricky, because the templating here isn't actually HAML, it's jquery/tmpl. The ${} stuff isn't expanded at HTML generation time, it's included in the HTML and then the JS uses that as a template later.

Probably what we'll need is like, to refactor this template to use the value returned by that petThumbnailUrl function. Haven't dug into this yet but that would be my guess!

Ohhh ok so, this section is a bit tricky, because the templating here isn't actually HAML, it's `jquery/tmpl`. The `${}` stuff isn't expanded at HTML generation time, it's included in the HTML and then the JS uses that as a template later. Probably what we'll need is like, to refactor this _template_ to use the value returned by that `petThumbnailUrl` function. Haven't dug into this yet but that would be my guess!
matchu commented 2024-08-31 12:18:24 -07:00
Owner
Copy link

Committed a modified version of this! Thank you!!

Committed a modified version of this! Thank you!!
matchu closed this pull request 2024-08-31 12:18:24 -07:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
matchu
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: OpenNeo/impress#2
No description provided.
Delete branch "dice:enhance-hashed-pets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?